Add support for exporting onnx split #15092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
|
Another one for you, @houseroad ? (Or farm it out appropriately) |
|
Sure, will check it. |
houseroad
approved these changes
Dec 21, 2018
* With the update of split output to dynamic list it breaks the export to onnx. Now split ir becomes two ops: 1. Dynamic[] <= Split(), and 2. out1, out2, out3 <= Prim::ListUnpack. In this fix these two consecutive ops get fused when being exported to onnx.
|
added seperate test cases for the two symbolics, thx. |
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@BowenBao thanks! |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jan 8, 2019
Summary: * With the update of split output to dynamic list it breaks the export to onnx. Now split ir becomes two ops: 1. Dynamic[] <= Split(), and 2. out1, out2, out3 <= Prim::ListUnpack. In this fix these two consecutive ops get fused when being exported to onnx. Pull Request resolved: pytorch/pytorch#15092 Reviewed By: dzhulgakov Differential Revision: D13583832 Pulled By: houseroad fbshipit-source-id: 3eb18c871e750921ad6d5cc179254bee9bcf4c99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now split ir becomes two ops: 1. Dynamic[] <= Split(), and 2. out1, out2, out3
<= Prim::ListUnpack. In this fix these two consecutive ops get fused when being
exported to onnx.