[BC-breaking] Set NonStrict as default for export_for_training #150941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmagogsfm
requested review from
angelayi,
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150941
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7183fb5 with merge base 061832b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D72724975 |
gmagogsfm
force-pushed
the
export-D72724975
branch
from
b995e48 to
d1c0f02
Compare
gmagogsfm
added a commit
to gmagogsfm/pytorch-1
that referenced
this pull request
Apr 10, 2025
…ch#150941) Summary: - Flip default value of `strict` argument from True to False on torch.export.export_for_training API - All callsites have been updated to provide this argument explicitly to avoid behavior change. - If you see any breakages, that means you may have a new callsite that is missed, please set `strict=True` explicitly to the callsite to mitigage. Test Plan: CI Differential Revision: D72724975
|
This pull request was exported from Phabricator. Differential Revision: D72724975 |
…ch#150941) Summary: - Flip default value of `strict` argument from True to False on torch.export.export_for_training API - All callsites have been updated to provide this argument explicitly to avoid behavior change. - If you see any breakages, that means you may have a new callsite that is missed, please set `strict=True` explicitly to the callsite to mitigage. Test Plan: CI Differential Revision: D72724975
gmagogsfm
force-pushed
the
export-D72724975
branch
from
d1c0f02 to
7183fb5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72724975 |
ydwu4
approved these changes
Apr 10, 2025
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
…ch#150941) Summary: - Flip default value of `strict` argument from True to False on torch.export.export_for_training API - All callsites have been updated to provide this argument explicitly to avoid behavior change. - If you see any breakages, that means you may have a new callsite that is missed, please set `strict=True` explicitly to the callsite to mitigage. Test Plan: CI Differential Revision: D72724975 Pull Request resolved: pytorch#150941 Approved by: https://github.com/ydwu4
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…ch#150941) Summary: - Flip default value of `strict` argument from True to False on torch.export.export_for_training API - All callsites have been updated to provide this argument explicitly to avoid behavior change. - If you see any breakages, that means you may have a new callsite that is missed, please set `strict=True` explicitly to the callsite to mitigage. Test Plan: CI Differential Revision: D72724975 Pull Request resolved: pytorch#150941 Approved by: https://github.com/ydwu4
|
@gmagogsfm , @ydwu4 since it is a break change and the comment of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
strictargument from True to False on torch.export.export_for_training APIstrict=Trueexplicitly to the callsite to mitigage.Test Plan: CI
Differential Revision: D72724975
cc @ezyang @gchanan