KEMBAR78
Fix uint view copy by eellison · Pull Request #151598 · pytorch/pytorch · GitHub
Skip to content

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Apr 17, 2025

Stack from ghstack (oldest at bottom):

Fix for #151156. We have some logic to undo our upcast prior to dtype bitcast. This pr cleans up that logic using dtypes in codegen.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151598

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (3 Unrelated Failures)

As of commit a867479 with merge base 300e0ee (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Fix for #151156. 


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov

[ghstack-poisoned]
eellison added a commit that referenced this pull request Apr 17, 2025
ghstack-source-id: 0a4d581
Pull Request resolved: #151598
@eellison eellison requested a review from jansel April 17, 2025 21:10
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 18, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor

atalman commented May 7, 2025

@pytorchbot cherry-pick --onto release/2.7 -c critical

@pytorchbot
Copy link
Collaborator

Cherry picking #151598

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 9ccdeae7db5a06372bef59b47ba962d39baff7b5 returned non-zero exit code 1

Auto-merging test/inductor/test_cuda_repro.py
CONFLICT (content): Merge conflict in test/inductor/test_cuda_repro.py
Auto-merging torch/_inductor/codegen/triton.py
error: could not apply 9ccdeae7db5... Fix uint view copy (#151598)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@atalman
Copy link
Contributor

atalman commented May 7, 2025

cc @eellison and @zou3519 please perform manual cherry-pick

eellison added a commit that referenced this pull request May 22, 2025
Fix for #151156. We have some logic to undo our upcast prior to dtype bitcast. This pr cleans up that logic using dtypes in codegen.

Pull Request resolved: #151598
Approved by: https://github.com/zou3519
ghstack dependencies: #151562
atalman pushed a commit that referenced this pull request May 22, 2025
Fix for #151156. We have some logic to undo our upcast prior to dtype bitcast. This pr cleans up that logic using dtypes in codegen.

Pull Request resolved: #151598
Approved by: https://github.com/zou3519
ghstack dependencies: #151562
@github-actions github-actions bot deleted the gh/eellison/783/head branch June 7, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants