KEMBAR78
[Set] Support sets in VariableBuilder by guilhermeleobas · Pull Request #153150 · pytorch/pytorch · GitHub
Skip to content

[Set] Support sets in VariableBuilder #153150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 54 commits into from
Closed

[Set] Support sets in VariableBuilder #153150

wants to merge 54 commits into from

Conversation

@guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented May 8, 2025 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@guilhermeleobas
Update
55bb7fa 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request May 8, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented May 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153150

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 98ac67e with merge base 660dbea (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guilhermeleobas guilhermeleobas mentioned this pull request May 8, 2025
Closed
This was referenced May 8, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@guilhermeleobas
Update
7871b28 
[ghstack-poisoned]
@guilhermeleobas
Update
eacdbb4 
[ghstack-poisoned]
@guilhermeleobas
Update
437a040 
[ghstack-poisoned]
@guilhermeleobas
Update
0fb8d15 
[ghstack-poisoned]
@guilhermeleobas
Update
829c4cd 
[ghstack-poisoned]
@guilhermeleobas
Update
fdba28d 
[ghstack-poisoned]
@guilhermeleobas
Update
d365f07 
[ghstack-poisoned]
@guilhermeleobas
Update
52cff75 
[ghstack-poisoned]
@guilhermeleobas
Update
3af9a3e 
[ghstack-poisoned]
guilhermeleobas and others added 2 commits June 26, 2025 19:15
@guilhermeleobas
Update
ad021a0 
[ghstack-poisoned]
@guilhermeleobas
Update
bd078d8 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/guilhermeleobas/156/orig onto refs/remotes/origin/main because #154366 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/153150)

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154366

@guilhermeleobas
Update
4b9bb20 
[ghstack-poisoned]
@guilhermeleobas
Update
cb7e375 
[ghstack-poisoned]
@guilhermeleobas
Update
d6c8177 
[ghstack-poisoned]
@guilhermeleobas
Update
9a6ee8f 
[ghstack-poisoned]
@guilhermeleobas
Update
bb5c1cd 
[ghstack-poisoned]
@guilhermeleobas
Update
d47fd1f 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/guilhermeleobas/156/orig onto refs/remotes/origin/viable/strict because #154366 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/153150)

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154366

@guilhermeleobas
Update
79a01ef 
[ghstack-poisoned]
@guilhermeleobas
Update
24ae40e 
[ghstack-poisoned]
@guilhermeleobas
Update
98ac67e 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #154366

pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
[FrozenSet] Fixes for FrozenSet (#152991)
f651e28 
Pull Request resolved: #152991
Approved by: https://github.com/zou3519
ghstack dependencies: #153150
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
[Generator] Implement generator.__contains__ (#154539)
2b82c61 
Pull Request resolved: #154539
Approved by: https://github.com/williamwen42, https://github.com/zou3519
ghstack dependencies: #153150, #152991
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
[Dynamo] [SetSubclass] Add support for user defined sets (#153553)
22abe6d 
Pull Request resolved: #153553
Approved by: https://github.com/williamwen42, https://github.com/zou3519
ghstack dependencies: #153150, #152991, #154539
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
[Dynamo] [Set] Implement some binop operators for dict/set/frozenset/…
11c7105 
…dict_keys (#154063)

Pull Request resolved: #154063
Approved by: https://github.com/williamwen42, https://github.com/zou3519
ghstack dependencies: #153150, #152991, #154539, #153553
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
[Dynamo] [Set] Raise TypeError if object is unhashable (#154064)
f9544f1 
Pull Request resolved: #154064
Approved by: https://github.com/Skylion007
ghstack dependencies: #153150, #152991, #154539, #153553, #154063
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
[Dynamo] [Set] Raise TypeError in set.union(...) and "__or__" (#154065)
c51da57 
Pull Request resolved: #154065
Approved by: https://github.com/williamwen42
ghstack dependencies: #153150, #152991, #154539, #153553, #154063, #154064
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
[Dynamo] [Set] Add comparison for set subclass (#154066)
308b88b 
Pull Request resolved: #154066
Approved by: https://github.com/Skylion007
ghstack dependencies: #153150, #152991, #154539, #153553, #154063, #154064, #154065
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
[Dynamo] [FrozensetSubclass] Add support for user defined frozensets (#…
0e7f02f 
…154263)

Pull Request resolved: #154263
Approved by: https://github.com/williamwen42
ghstack dependencies: #153150, #152991, #154539, #153553, #154063, #154064, #154065, #154066
pytorchmergebot pushed a commit that referenced this pull request Jul 4, 2025
@guilhermeleobas @pytorchmergebot
Ensure Dynamo can trace through explicit dunder method call (#154366)
dfcda61 
Pull Request resolved: #154366
Approved by: https://github.com/zou3519
ghstack dependencies: #153150, #152991, #154539, #153553, #154063, #154064, #154065, #154066, #154263
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Jul 14, 2025
@facebook-github-bot
Support sets in VariableBuilder (#153150)
4c450c6 
Summary:
X-link: pytorch/pytorch#153150
Approved by: https://github.com/zou3519

Reviewed By: jeanschmidt

Differential Revision: D77790773

fbshipit-source-id: 9e606b4e86bb6e63cf34a409fc70a4f72769e436
@github-actions github-actions bot deleted the gh/guilhermeleobas/145/head branch August 3, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@williamwen42 williamwen42 williamwen42 requested changes

@zou3519 zou3519 zou3519 approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@guilhermeleobas @pytorchmergebot @Skylion007 @zou3519 @williamwen42 @pytorchbot