[ONNX] Add test for decomp_table update #153671
Conversation
titaiwangms
requested review from
justinchuby,
shubhambhokare1 and
wschin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153671
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 44234fd with merge base 7e16cb9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
test/onnx/exporter/test_api.py
Outdated
| torch.ops.custom.add.default: onnx_add, | ||
| } | ||
|
|
||
| onnx_program = torch.onnx.export( |
There was a problem hiding this comment.
Would it be a good idea to also test that it will be decomp'd if custom_translation_table is not provided?
titaiwangms
added
module: onnx
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.7 -c critical |
Added a test to strengthen the case for cherry-picking #153168. The original PR didn’t include this test since the fix for decomp_table and the registry was already covered by existing tests. However, it's reasonable to include a dedicated test for the specific issue (#150367 ) when considering the cherry-pick. Pull Request resolved: #153671 Approved by: https://github.com/justinchuby (cherry picked from commit 658d17d)
Cherry picking #153671The cherry pick PR is at #153729 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Added a test to strengthen the case for cherry-picking #153168. The original PR didn’t include this test since the fix for decomp_table and the registry was already covered by existing tests. However, it's reasonable to include a dedicated test for the specific issue (#150367 ) when considering the cherry-pick. Pull Request resolved: #153671 Approved by: https://github.com/justinchuby
* [ONNX] Update decomposition logic to loop over onnx registry (#151826) Fixes #150367 This PR makes decomposition table from onnx registry, which includes registered ops not only ATen and prim. This will help to keep the custom ops that are specified in the custom_translation table from decomposition during ONNX export. Pull Request resolved: #151826 Approved by: https://github.com/justinchuby (cherry picked from commit 6cd1741) * [ONNX] Add test for decomp_table update (#153671) Added a test to strengthen the case for cherry-picking #153168. The original PR didn’t include this test since the fix for decomp_table and the registry was already covered by existing tests. However, it's reasonable to include a dedicated test for the specific issue (#150367 ) when considering the cherry-pick. Pull Request resolved: #153671 Approved by: https://github.com/justinchuby --------- Co-authored-by: titaiwangms <titaiwang@microsoft.com>
4 participants
Added a test to strengthen the case for cherry-picking #153168. The original PR didn’t include this test since the fix for decomp_table and the registry was already covered by existing tests. However, it's reasonable to include a dedicated test for the specific issue (#150367 ) when considering the cherry-pick.