KEMBAR78
[3.13] Remove all profiler related skips by malfet · Pull Request #153857 · pytorch/pytorch · GitHub
Skip to content

[3.13] Remove all profiler related skips #153857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[3.13] Remove all profiler related skips #153857

wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented May 19, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

As underlying issue were fixed by #153848

Fixes #142166

@malfet
Update
9a8a010 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented May 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153857

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 51 Pending

As of commit b39e960 with merge base ae0e8f0 (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 19, 2025
@malfet malfet requested a review from williamwen42 May 19, 2025 22:05
@malfet malfet added the ci-no-td Do not run TD on this PR label May 19, 2025
@malfet malfet added the keep-going Don't stop on first failure, keep running tests until the end label May 20, 2025
@malfet
Update
b39e960 
[ghstack-poisoned]
malfet added a commit that referenced this pull request May 20, 2025
@malfet
[3.13] Remove all profiler related skips
62653f3 
As underlying issue were fixed by #153848

Fixes #142166

ghstack-source-id: c97acbe
Pull Request resolved: #153857
@malfet
Copy link
Contributor Author

malfet commented May 20, 2025

@pytorchbot merge -f "Let's test in prod"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/344/head branch June 19, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR keep-going Don't stop on first failure, keep running tests until the end Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @williamwen42