[list] Implement list.count #153969

guilhermeleobas · 2025-05-20T19:06:29Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

[ghstack-poisoned]

pytorch-bot · 2025-05-20T19:06:32Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153969

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a4b9391 with merge base 524e827 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

ghstack-source-id: 77ec8ef Pull Request resolved: #153969

[ghstack-poisoned]

ghstack-source-id: 0b369ca Pull Request resolved: #153969

XuehaiPan · 2025-06-14T15:10:13Z

torch/_dynamo/polyfills/__init__.py

+def count(iterator, value):
+    return sum(it is value or it == value for it in iterator)


Move this to polyfills.operator as operator.countOf.

[ghstack-poisoned]

zou3519 · 2025-06-20T15:20:46Z

a.py

@@ -1,34 +0,0 @@
-# import torch


Uh, what is this file lol

This shouldn't be here 😅

Oh, wait. Did I commit this file in a previous PR? lol

Seems like it haha

Oh man 🤦

it looks like this file doesn't exist in main or viable/strict.

I don't know how to actually fix this. a.py is not showing up on other branches or on main but it being tracked in this PR.

edit: git blame show the file was added in #150790 but it is not there as well

Oh: mistery solved! Found where the file came from.

zou3519

Seems reasonable. The operator.countOf feedback seems reasonable too as long as it works

[ghstack-poisoned]

torch/_dynamo/polyfills/operator.py

[ghstack-poisoned]

pytorchmergebot · 2025-06-26T14:06:04Z

Rebased gh/guilhermeleobas/180/orig onto refs/remotes/origin/viable/strict because #156339 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/153969)

[ghstack-poisoned]

pytorchmergebot · 2025-07-01T01:25:00Z

Starting merge as part of PR stack under #156339

[ghstack-poisoned]

pytorchmergebot · 2025-07-03T16:12:40Z

Rebased gh/guilhermeleobas/180/orig onto refs/remotes/origin/main because #156339 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/153969)

pytorchmergebot · 2025-07-03T16:14:15Z

Starting merge as part of PR stack under #156339

[ghstack-poisoned]

pytorchmergebot · 2025-07-04T21:08:44Z

Rebased gh/guilhermeleobas/180/orig onto refs/remotes/origin/main because #156339 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/153969)

pytorchmergebot · 2025-07-04T21:10:16Z

Starting merge as part of PR stack under #156339

pytorchmergebot · 2025-07-07T14:44:59Z

Starting merge as part of PR stack under #156339

Pull Request resolved: #156148 Approved by: https://github.com/zou3519 ghstack dependencies: #153969

Pull Request resolved: #156242 Approved by: https://github.com/Skylion007, https://github.com/zou3519 ghstack dependencies: #153969, #156148

Pull Request resolved: #156270 Approved by: https://github.com/Skylion007, https://github.com/zou3519 ghstack dependencies: #153969, #156148, #156242

Pull Request resolved: #156271 Approved by: https://github.com/zou3519 ghstack dependencies: #153969, #156148, #156242, #156270

Pull Request resolved: #156339 Approved by: https://github.com/zou3519 ghstack dependencies: #153969, #156148, #156242, #156270, #156271

Update

3686b9b

[ghstack-poisoned]

guilhermeleobas mentioned this pull request May 20, 2025

Add CPython list/tuple tests #150790

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels May 20, 2025

Update

0b4dc7b

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request May 20, 2025

[list] Implement list.count

98761ca

ghstack-source-id: 77ec8ef Pull Request resolved: #153969

pytorchbot added the open source label May 20, 2025

guilhermeleobas added a commit that referenced this pull request May 21, 2025

[list] Implement list.count

44cf577

ghstack-source-id: 77ec8ef Pull Request resolved: #153969

Update

724a5d3

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jun 14, 2025

[list] Implement list.count

582bbed

ghstack-source-id: 0b369ca Pull Request resolved: #153969

XuehaiPan reviewed Jun 14, 2025

View reviewed changes

Update

e767b67

[ghstack-poisoned]

zou3519 reviewed Jun 20, 2025

View reviewed changes

zou3519 approved these changes Jun 20, 2025

View reviewed changes

guilhermeleobas added the release notes: dynamo label Jun 20, 2025

guilhermeleobas added 3 commits June 20, 2025 15:35

Update

5a5c2ce

[ghstack-poisoned]

Update

4229acd

[ghstack-poisoned]

Update

1d2c25f

[ghstack-poisoned]

guilhermeleobas marked this pull request as ready for review June 20, 2025 18:47

guilhermeleobas requested a review from XuehaiPan June 20, 2025 18:47

guilhermeleobas added 2 commits June 20, 2025 17:12

Update

b86e661

[ghstack-poisoned]

Update

6ec16a4

[ghstack-poisoned]

XuehaiPan reviewed Jun 21, 2025

View reviewed changes

torch/_dynamo/polyfills/operator.py Show resolved Hide resolved

guilhermeleobas and others added 3 commits June 23, 2025 15:18

Update

7527c3c

[ghstack-poisoned]

Update

ea795b8

[ghstack-poisoned]

Update

937ceb3

[ghstack-poisoned]

XuehaiPan approved these changes Jun 26, 2025

View reviewed changes

guilhermeleobas added 3 commits June 27, 2025 15:51

Update

4c3b3d0

[ghstack-poisoned]

Update

952e5f4

[ghstack-poisoned]

Update

2e7bbde

[ghstack-poisoned]

Update

95abbf5

[ghstack-poisoned]

Update

a4b9391

[ghstack-poisoned]

pytorchmergebot closed this in 034e996 Jul 7, 2025

pytorchmergebot pushed a commit that referenced this pull request Jul 7, 2025

[list] Raise exception in invalid list method call (#156148)

e49acfc

Pull Request resolved: #156148 Approved by: https://github.com/zou3519 ghstack dependencies: #153969

pytorchmergebot pushed a commit that referenced this pull request Jul 7, 2025

[list] Implement list.remove (#156242)

c1d69d5

Pull Request resolved: #156242 Approved by: https://github.com/Skylion007, https://github.com/zou3519 ghstack dependencies: #153969, #156148

pytorchmergebot added the Merged label Jul 7, 2025

pytorchmergebot pushed a commit that referenced this pull request Jul 7, 2025

Implement list.__add__ and list.__iadd__ (#156270)

689fba0

Pull Request resolved: #156270 Approved by: https://github.com/Skylion007, https://github.com/zou3519 ghstack dependencies: #153969, #156148, #156242

pytorchmergebot pushed a commit that referenced this pull request Jul 7, 2025

[list] Add list.__mul__ and list.__imul__ (#156271)

d74ccf4

Pull Request resolved: #156271 Approved by: https://github.com/zou3519 ghstack dependencies: #153969, #156148, #156242, #156270

pytorchmergebot pushed a commit that referenced this pull request Jul 7, 2025

[list] Add list.__delitem__ (#156339)

eda0a9c

Pull Request resolved: #156339 Approved by: https://github.com/zou3519 ghstack dependencies: #153969, #156148, #156242, #156270, #156271

github-actions bot deleted the gh/guilhermeleobas/148/head branch August 7, 2025 02:20

		def count(iterator, value):
		return sum(it is value or it == value for it in iterator)

[list] Implement list.count #153969

[list] Implement list.count #153969

Uh oh!

Conversation

guilhermeleobas commented May 20, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153969

✅ No Failures

Uh oh!

XuehaiPan Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

zou3519 Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zou3519 Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zou3519 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pytorchmergebot commented Jun 26, 2025

Uh oh!

pytorchmergebot commented Jul 1, 2025

Uh oh!

pytorchmergebot commented Jul 3, 2025

Uh oh!

pytorchmergebot commented Jul 3, 2025

Uh oh!

pytorchmergebot commented Jul 4, 2025

Uh oh!

pytorchmergebot commented Jul 4, 2025

Uh oh!

pytorchmergebot commented Jul 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guilhermeleobas commented May 20, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented May 20, 2025 •

edited

Loading

guilhermeleobas Jun 20, 2025 •

edited

Loading

guilhermeleobas Jun 20, 2025 •

edited

Loading