KEMBAR78
[Inductor]Cleanup autotune_fallback_to_aten post-deprecation by joaquinmartis · Pull Request #154331 · pytorch/pytorch · GitHub
Skip to content

[Inductor]Cleanup autotune_fallback_to_aten post-deprecation #154331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Inductor]Cleanup autotune_fallback_to_aten post-deprecation #154331

wants to merge 3 commits into from

Conversation

joaquinmartis
Copy link
Contributor

@joaquinmartis joaquinmartis commented May 25, 2025 •
edited by pytorch-bot bot
Loading

Fixes #153298

This PR is the 3rd and final step of #147479
All references to autotune_fallback_to_aten have been removed, and the feature is now deprecated.
All calls to should_fallback_to_aten() were also removed, as they were deemed unnecessary.

henrylhtsang

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented May 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154331

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 0f26bcb with merge base 24980d2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 25, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@henrylhtsang henrylhtsang self-requested a review May 27, 2025 16:34
@henrylhtsang
Copy link
Contributor

Need CLA, linter, and add "not user facing"

for linter, find some guide in wiki maybe.

@henrylhtsang henrylhtsang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 27, 2025
@joaquinmartis
Copy link
Contributor Author

What do you mean by "add "not user facing" "? Do you mean changing the description of the pull request?

@henrylhtsang
Copy link
Contributor

What do you mean by "add "not user facing" "? Do you mean changing the description of the pull request?

like this
This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

@joaquinmartis
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 27, 2025
@joaquinmartis
Copy link
Contributor Author

Hello, I’ve fixed all the linting issues but now now I am encountering build errors which I do not understand. Can you help me?

@henrylhtsang
Copy link
Contributor

@joaquinmartis I feel like maybe the errors are transient or underlying errors.

Can you try @ pytorchbot rebase -b main

@joaquinmartis
Copy link
Contributor Author

@pytorchbot rebase -b main

@pytorch-bot
Copy link

pytorch-bot bot commented May 28, 2025

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

@henrylhtsang
Copy link
Contributor

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased main onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout main && git pull --rebase)

@henrylhtsang
Copy link
Contributor

@joaquinmartis should be good to land. Try something like @ pytorchbot merge

@joaquinmartis
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@henrylhtsang henrylhtsang mentioned this pull request Jun 2, 2025
Closed
iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull request Jun 4, 2025
@joaquinmartis @iupaikov-amd
[Inductor]Cleanup autotune_fallback_to_aten post-deprecation (pytorch…
a4fa6fd 
…#154331)

Fixes pytorch#153298

This PR is the 3rd and final step of pytorch#147479
All references to autotune_fallback_to_aten have been removed, and the feature is now deprecated.
All calls to should_fallback_to_aten() were also removed, as they were deemed unnecessary.

[henrylhtsang](https://github.com/henrylhtsang)

Pull Request resolved: pytorch#154331
Approved by: https://github.com/henrylhtsang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrylhtsang henrylhtsang henrylhtsang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup autotune_fallback_to_aten post-deprecation

4 participants

@joaquinmartis @henrylhtsang @pytorchmergebot @pytorchbot