Turn on compile with NVSHMEM #154538
Closed
Turn on compile with NVSHMEM #154538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154538
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a9095a4 with merge base 241f8dc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
We'll need https://pypi.nvidia.com/nvidia-nvshmem-cu12/ added to the release builds at some point if they aren't already |
|
Thanks @Skylion007 . Thinking the same. Do you know how I can do that? |
|
At the very least, you need to add it to here: and have @atalman or someone with write access upload a binary to the S3 so the nightly builds do not fail (you need to regenerate the YAMLs after editing this file) Trigger CI Flows binary |
|
I added the extra dependency in #154568. |
Before: `USE_NVSHMEM=1` need to be explicit set in build environment. After: `USE_NVSHMEM=1` is the default for CUDA/Rocm on Linux. [ghstack-poisoned]
ngimel
approved these changes
May 29, 2025
|
If we want binaries to have nvshmem, we need to make sure it's installed and discoverable for binary builds? |
Before: `USE_NVSHMEM=1` need to be explicit set in build environment. After: `USE_NVSHMEM=1` is the default for CUDA/Rocm on Linux. [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
Before: `USE_NVSHMEM=1` need to be explicit set in build environment. After: `USE_NVSHMEM=1` is the default for CUDA/Rocm on Linux. Pull Request resolved: pytorch#154538 Approved by: https://github.com/ngimel
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 4, 2025
NVSHMEM 3.2.5 (released Mar 2025) have both cu11 and cu12 builds. See: https://pypi.nvidia.com/nvidia-nvshmem-cu12/ https://pypi.nvidia.com/nvidia-nvshmem-cu11/ Pull Request resolved: #154568 Approved by: https://github.com/atalman ghstack dependencies: #154538
angelayi
pushed a commit
to angelayi/pytorch
that referenced
this pull request
Jun 5, 2025
Before: `USE_NVSHMEM=1` need to be explicit set in build environment. After: `USE_NVSHMEM=1` is the default for CUDA/Rocm on Linux. Pull Request resolved: pytorch#154538 Approved by: https://github.com/ngimel
angelayi
pushed a commit
to angelayi/pytorch
that referenced
this pull request
Jun 5, 2025
NVSHMEM 3.2.5 (released Mar 2025) have both cu11 and cu12 builds. See: https://pypi.nvidia.com/nvidia-nvshmem-cu12/ https://pypi.nvidia.com/nvidia-nvshmem-cu11/ Pull Request resolved: pytorch#154568 Approved by: https://github.com/atalman ghstack dependencies: pytorch#154538
atalman
added a commit
to atalman/pytorch
that referenced
this pull request
Jul 10, 2025
This reverts commit 3685b10.
atalman
added a commit
that referenced
this pull request
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Before:
USE_NVSHMEM=1need to be explicit set in build environment.After:
USE_NVSHMEM=1is the default for CUDA/Rocm on Linux.