KEMBAR78
Fix github branch prefix v by ailzhang · Pull Request #15552 · pytorch/pytorch · GitHub
Skip to content

Fix github branch prefix v #15552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix github branch prefix v #15552

wants to merge 1 commit into from

Conversation

@ailzhang
Copy link
Contributor

Fixes #15519 .

soumith
soumith approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@soumith soumith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test maybe?

@ailzhang
Copy link
Contributor Author

@soumith We don't have a release/branch in pytorch/vision with hub.py except master branch. I tested on my own fork of vision, but I think it might be a bad idea to

  • let CI depend on my fork of vision
  • create a new branch v0.x.x in pytorch/vision when it's not a release, it might confuses users. :(
    I would prefer to wait until we have next release of torchvision and then add a test for it?

@soumith
Copy link
Member

soumith commented Dec 26, 2018

@ailzhang ok that sounds good

facebook-github-bot
facebook-github-bot reviewed Dec 26, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ailzhang
Copy link
Contributor Author

ailzhang commented Dec 27, 2018 •
edited
Loading

@soumith Can we include this in the next minor release? (Couldn't find the right label for it :P Thanks!

@soumith soumith added this to the 1.0.1 milestone Dec 27, 2018
@soumith soumith added the cherry-picked This PR was cherry-picked onto a release branch from master label Jan 17, 2019
soumith pushed a commit that referenced this pull request Jan 17, 2019
@soumith
Fix github branch prefix v (#15552)
198e5ae 
Summary:
Fixes #15519 .
Pull Request resolved: #15552

Differential Revision: D13550780

Pulled By: ailzhang

fbshipit-source-id: b117e5ced42de207b91045bffcee8907dd73201e
soumith pushed a commit that referenced this pull request Jan 18, 2019
@soumith
Fix github branch prefix v (#15552)
a4e2d27 
Summary:
Fixes #15519 .
Pull Request resolved: #15552

Differential Revision: D13550780

Pulled By: ailzhang

fbshipit-source-id: b117e5ced42de207b91045bffcee8907dd73201e
@ezyang ezyang added the merged label Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@soumith soumith soumith approved these changes

Assignees

No one assigned

Labels

cherry-picked This PR was cherry-picked onto a release branch from master

Projects

None yet

Milestone

1.0.1

Development

Successfully merging this pull request may close these issues.

torch.hub cannot download if branch name starts with v

4 participants

@ailzhang @soumith @facebook-github-bot @ezyang