KEMBAR78
[NOT FOR MERGE] Exploratory work on AOTInductor training by benjaminglass1 · Pull Request #155877 · pytorch/pytorch · GitHub
Skip to content

Conversation

@benjaminglass1
Copy link
Collaborator

@benjaminglass1 benjaminglass1 commented Jun 13, 2025

Stack from ghstack (oldest at bottom):

TODO for MVP:

  • Select between training and eval mode within the export model loaders.
  • Improve UI around parameter updates and gradients (i.e. users should not have to manually apply gradients and maintain a separate copy of the model to apply them to for this to work).
  • Determine why some tensor constants get dropped when doing AOTInductor training.
  • Ensure optimizer runtime is integrated into export performance stats. :( Maybe we can export the full forward_and_backward_pass function?
  • Break out unrelated code improvements into a separate PR.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155877

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit 67d6fc3 with merge base 1abff80 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 13, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 13, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 13, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 13, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 16, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 17, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 18, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 19, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jun 24, 2025
benjaminglass1 added a commit that referenced this pull request Jul 10, 2025
[ghstack-poisoned]
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 15, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 15, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 15, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 15, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 16, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 17, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 21, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 23, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 24, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 28, 2025
@benjaminglass1
Copy link
Collaborator Author

Closing this, as we've decided not to pursue the AOTInductor training work at this time.

@github-actions github-actions bot deleted the gh/benjaminglass1/89/head branch September 25, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants