KEMBAR78
[iter] Add support for sequence protocol in `iter(..)` by guilhermeleobas · Pull Request #156371 · pytorch/pytorch · GitHub
Skip to content

[iter] Add support for sequence protocol in iter(..) #156371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[iter] Add support for sequence protocol in iter(..) #156371

wants to merge 19 commits into from

Conversation

@guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Jun 18, 2025 •
edited by pytorch-bot bot
Loading

@guilhermeleobas
Update
1c2f253 
[ghstack-poisoned]
This was referenced Jun 18, 2025
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156371

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 548d5f1 with merge base 9d32aa9 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guilhermeleobas added a commit that referenced this pull request Jun 18, 2025
@guilhermeleobas
[iter] Add support for sequence protocol in iter(..)
dae6c6c 
ghstack-source-id: 05ae4a4
Pull Request resolved: #156371
@guilhermeleobas
Update
8f5ab09 
[ghstack-poisoned]
@guilhermeleobas
Update
1064963 
[ghstack-poisoned]
This was referenced Jun 19, 2025
Closed
Closed
guilhermeleobas and others added 5 commits June 20, 2025 14:34
@guilhermeleobas
Update
4574c84 
[ghstack-poisoned]
@guilhermeleobas
Update
c57f1a0 
[ghstack-poisoned]
@guilhermeleobas
Update
6a5f644 
[ghstack-poisoned]
@guilhermeleobas
Update
9bd8f54 
[ghstack-poisoned]
@guilhermeleobas
Update
a33bafb 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas marked this pull request as ready for review June 24, 2025 13:30
@guilhermeleobas
Update
198dedb 
[ghstack-poisoned]
zou3519
zou3519 reviewed Jun 26, 2025
View reviewed changes
torch/_dynamo/polyfills/builtins.py
return functools.reduce(operator.add, iterable, start)


# TODO(guilhermeleobas): use substitute_in_graph for iter()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this possible?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. There are other builtins implemented using substitute_in_graph.

zou3519
zou3519 reviewed Jun 26, 2025
View reviewed changes
@guilhermeleobas
Update
936a7b0 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request Jul 8, 2025
Closed
@guilhermeleobas
Update
65283b2 
[ghstack-poisoned]
@guilhermeleobas
Update
828d123 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request Jul 16, 2025
Closed
rtimpe pushed a commit to rtimpe/pytorch that referenced this pull request Jul 17, 2025
@guilhermeleobas @rtimpe
[iter] Add support for sequence protocol in iter(..)
687f1cc 
ghstack-source-id: 360f5e3
Pull Request resolved: pytorch#156371
@guilhermeleobas
Update
f8498d2 
[ghstack-poisoned]
@rtimpe rtimpe mentioned this pull request Jul 21, 2025
Closed
@guilhermeleobas
Update
0108d8c 
[ghstack-poisoned]
@guilhermeleobas
Update
eed26d5 
[ghstack-poisoned]
rtimpe pushed a commit to rtimpe/pytorch that referenced this pull request Jul 24, 2025
@guilhermeleobas @rtimpe
[iter] Add support for sequence protocol in iter(..)
cabbdb0 
ghstack-source-id: 53e894e
Pull Request resolved: pytorch#156371
@rtimpe rtimpe mentioned this pull request Jul 24, 2025
Closed
@guilhermeleobas
Update
f69a4ab 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #156460

@guilhermeleobas
Update
c48bbb3 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158410

@guilhermeleobas
Update
bb5bd5c 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/guilhermeleobas/206/orig onto refs/remotes/origin/main because #158410 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/156371)

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158410

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #156460

@guilhermeleobas
Update
548d5f1 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/guilhermeleobas/206/orig onto refs/remotes/origin/main because #158410 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/156371)

@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158410

@guilhermeleobas guilhermeleobas mentioned this pull request Jul 29, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158410

pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2025
@guilhermeleobas @pytorchmergebot
[iter] support iter(callable, sentinel) (#156416)
4e3e3dc 
Pull Request resolved: #156416
Approved by: https://github.com/XuehaiPan, https://github.com/zou3519
ghstack dependencies: #156371
pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2025
@guilhermeleobas @pytorchmergebot
[iter] Wrap iter(..) call in a ObjectIteratorVariable (#156460)
f9be65c 
This object keeps track when the iterator is exhausted (raise Stopiteration).

Pull Request resolved: #156460
Approved by: https://github.com/zou3519
ghstack dependencies: #156371, #156416
pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2025
@guilhermeleobas @pytorchmergebot
[iter] Raise TypeError if iter arg cannot be iterable (#158410)
b97274e 
Pull Request resolved: #158410
Approved by: https://github.com/XuehaiPan, https://github.com/zou3519
ghstack dependencies: #156371, #156416, #156460
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@guilhermeleobas @yangw-dev
[iter] Add support for sequence protocol in iter(..) (#156371)
9d5cfa5 
Pull Request resolved: #156371
Approved by: https://github.com/zou3519
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@guilhermeleobas @yangw-dev
[iter] support iter(callable, sentinel) (#156416)
32e1948 
Pull Request resolved: #156416
Approved by: https://github.com/XuehaiPan, https://github.com/zou3519
ghstack dependencies: #156371
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@guilhermeleobas @yangw-dev
[iter] Wrap iter(..) call in a ObjectIteratorVariable (#156460)
802b802 
This object keeps track when the iterator is exhausted (raise Stopiteration).

Pull Request resolved: #156460
Approved by: https://github.com/zou3519
ghstack dependencies: #156371, #156416
yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@guilhermeleobas @yangw-dev
[iter] Raise TypeError if iter arg cannot be iterable (#158410)
d9d3162 
Pull Request resolved: #158410
Approved by: https://github.com/XuehaiPan, https://github.com/zou3519
ghstack dependencies: #156371, #156416, #156460
@github-actions github-actions bot deleted the gh/guilhermeleobas/183/head branch August 29, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo open source release notes: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guilhermeleobas @pytorchmergebot @zou3519 @pytorchbot