[ROCm][Windows] Fixing undefined symbol linker error after exposing MIOpen symbols #156479

tvukovic-amd · 2025-06-20T07:23:56Z

Fixing undefined symbol linker error after exposing MIOpen symbols.
This fix:

Hipifies aten/src/ATen/miopen and aten/src/ATen/native/miopen files
Adds aten/src/ATen/miopen and aten/src/ATen/native/miopen hipified source files to all_hip_cpp list

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

pytorch-bot · 2025-06-20T07:24:00Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156479

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

VolumeLimitExceeded Issue for linux.2xlarge and linux.4xlarge

✅ You can merge normally! (1 Unrelated Failure)

As of commit 981cdb0 with merge base 2d39a48 ():

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable) (gh) (#153987)
MISSING REGRESSION TEST

This comment was automatically generated by Dr. CI and updates every 15 minutes.

tvukovic-amd · 2025-06-20T07:34:58Z

@pytorchbot label "topic: not user facing"

jeffdaily · 2025-06-23T21:02:11Z

I don't understand why this is needed. We're not getting missing symbols in our CI or nightly wheels on linux.

tvukovic-amd · 2025-06-24T15:39:33Z

I don't understand why this is needed. We're not getting missing symbols in our CI or nightly wheels on linux.

TORCH_CUDA_CPP_API macro is added in aten/src/ATen/miopen and aten/src/ATen/native/miopen files. It defines __declspec(dllexport)/__declspec(dllimport) for Windows or __attribute__((__visibility__("default"))) for Linux.
On Windows this leads to lld-link: error: undefined symbol: __declspec(dllimport) error for all structs from aten/src/ATen/miopen and aten/src/ATen/native/miopen while linking torch_hip.dll.
TORCH_CUDA_CPP_API needs to be hipified to TORCH_HIP_CPP_API on ROCm usage according to [ROCm][Windows] Fix export macros, so hipified files should be used to link with torch_hip.dll.

jeffdaily

The miopen source files should not be hipified. They should contain the necessary HIP calls directly. Please try manually hipifiying those symbols under the miopen source tree.

TORCH_CUDA_CPP_API --> TORCH_HIP_CPP_API

Then commit those changes to this PR.

tvukovic-amd · 2025-06-25T10:23:52Z

The miopen source files should not be hipified. They should contain the necessary HIP calls directly. Please try manually hipifiying those symbols under the miopen source tree.

TORCH_CUDA_CPP_API --> TORCH_HIP_CPP_API

Then commit those changes to this PR.

I rebuilt pytorch with this change to double check and it works on Windows as expected, I see that you already pushed changes.

jeffdaily · 2025-06-26T20:37:08Z

@pytorchbot rebase

pytorchmergebot · 2025-06-26T20:38:40Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

This reverts commit d7bda96.

pytorchmergebot · 2025-06-26T20:38:44Z

Successfully rebased fix_miopen_hipify onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_miopen_hipify && git pull --rebase)

jeffdaily · 2025-06-27T02:36:35Z

@pytorchbot merge

pytorchmergebot · 2025-06-27T02:38:35Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…IOpen symbols (pytorch#156479) Fixing undefined symbol linker error after [exposing MIOpen symbols](pytorch#154545). This fix: - Hipifies `aten/src/ATen/miopen` and `aten/src/ATen/native/miopen` files - Adds `aten/src/ATen/miopen` and `aten/src/ATen/native/miopen` hipified source files to `all_hip_cpp` list Pull Request resolved: pytorch#156479 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>

…IOpen symbols (#2415) Changing TORCH_CUDA_CPP_API macros to TORCH_HIP_CPP in MIOpen header files according to closed [PR](pytorch#156479) in pytorch upstream. --------- Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com> Co-authored-by: Jithun Nair <jithun.nair@amd.com> Co-authored-by: Ethan Wee <Ethan.Wee@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> Co-authored-by: Xinya Zhang <Xinya.Zhang@amd.com> Co-authored-by: Prachi Gupta <pracgupt@amd.com> Co-authored-by: Dmitry Nikolaev <139769634+dnikolaev-amd@users.noreply.github.com> Co-authored-by: iupaikov-amd <Iurii.Paikov@amd.com> Co-authored-by: omkar kakarparthi <75638701+okakarpa@users.noreply.github.com> Co-authored-by: Jeff Daily <jeff.daily@amd.com> Co-authored-by: rocm-mici <49319081+rocm-mici@users.noreply.github.com> Co-authored-by: Michael Halkenhäuser <michaelhalk@web.de> Co-authored-by: Hashem Hashemi <hashem.hashemi@amd.com> Co-authored-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com> Co-authored-by: Andres Lugo <108368282+alugorey@users.noreply.github.com> Co-authored-by: pmaybank <113125070+pmaybank@users.noreply.github.com> Co-authored-by: pnikolic-amd <pnikolic@amd.com> Co-authored-by: Jerry Mannil <65309407+jerrymannil@users.noreply.github.com> Co-authored-by: Sampsa Riikonen <sriikone@amd.com> Co-authored-by: Ramya Ramineni <62723901+rraminen@users.noreply.github.com> Co-authored-by: pytorchbot <soumith+bot@pytorch.org> Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com> Co-authored-by: rzou <zou3519@gmail.com> Co-authored-by: atalman <atalman@fb.com> Co-authored-by: David Berard <dberard@fb.com> Co-authored-by: Frank Lin <eee4017@gmail.com> Co-authored-by: Wei Wang <weiwan@nvidia.com> Co-authored-by: Cao E <e.cao@intel.com> Co-authored-by: Sidharth Subbarao <55903556+Sidharth123-cpu@users.noreply.github.com> Co-authored-by: Camyll Harajli <camyllh@meta.com> Co-authored-by: Aditya Tewari <aditya.tewari@arm.com> Co-authored-by: Christopher Sidebottom <chris.sidebottom@arm.com> Co-authored-by: Ryo Suzuki <ryo.suzuki@arm.com> Co-authored-by: Ye Tao <ye.tao@arm.com> Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com> Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com> Co-authored-by: Luca Wehrstedt <lcw@meta.com> Co-authored-by: Robert Hardwick <robert.hardwick@arm.com> Co-authored-by: Svetlana Karslioglu <svekars@meta.com> Co-authored-by: Michael Lazos <mlazos@meta.com> Co-authored-by: bobrenjc93 <bobren@meta.com> Co-authored-by: Nikita Shulga <nshulga@meta.com> Co-authored-by: Jane Xu <janeyx@meta.com> Co-authored-by: charlifu <charlifu@amd.com> Co-authored-by: Jack Taylor <108682042+jataylo@users.noreply.github.com> Co-authored-by: Nichols A. Romero <165712832+naromero77amd@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Sriram Kumar <skishore@amd.com> Co-authored-by: Divin Honnappa <divin.honnappa@amd.com> Co-authored-by: akashveramd <Akash.Verma3@amd.com>

tvukovic-amd requested review from jeffdaily and jithunnair-amd as code owners June 20, 2025 07:23

pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Jun 20, 2025

pytorchbot added the open source label Jun 20, 2025

pytorch-bot bot added the topic: not user facing topic category label Jun 20, 2025

jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 21, 2025

jeffdaily requested changes Jun 24, 2025

View reviewed changes

jeffdaily self-requested a review June 24, 2025 21:48

jeffdaily added the ciflow/rocm Trigger "default" config CI on ROCm label Jun 24, 2025

jeffdaily approved these changes Jun 26, 2025

View reviewed changes

tvukovic-amd and others added 3 commits June 26, 2025 20:38

fix miopen files hipify

dc55305

Revert "fix miopen files hipify"

0d36cfb

This reverts commit d7bda96.

use TORCH_HIP_CPP_API in miopen files

981cdb0

pytorchmergebot force-pushed the fix_miopen_hipify branch from 4bc1cc6 to 981cdb0 Compare June 26, 2025 20:38

pytorch-bot bot removed the ciflow/rocm Trigger "default" config CI on ROCm label Jun 26, 2025

jeffdaily added the ciflow/rocm Trigger "default" config CI on ROCm label Jun 27, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 27, 2025

pytorchmergebot added the merging label Jun 27, 2025

pytorchmergebot added the Merged label Jun 27, 2025

pytorchmergebot closed this in 968f90c Jun 27, 2025

pytorchmergebot removed the merging label Jun 27, 2025

tvukovic-amd mentioned this pull request Jul 23, 2025

[ROCm][Windows] Fixing undefined symbol linker error after exposing MIOpen symbols #158918

Closed

tvukovic-amd mentioned this pull request Jul 25, 2025

[ROCm][Windows] Fixing undefined symbol linker error after exposing MIOpen symbols ROCm/pytorch#2415

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ROCm][Windows] Fixing undefined symbol linker error after exposing MIOpen symbols #156479

[ROCm][Windows] Fixing undefined symbol linker error after exposing MIOpen symbols #156479

Uh oh!

tvukovic-amd commented Jun 20, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

tvukovic-amd commented Jun 20, 2025

Uh oh!

jeffdaily commented Jun 23, 2025

Uh oh!

tvukovic-amd commented Jun 24, 2025

Uh oh!

jeffdaily left a comment

Uh oh!

tvukovic-amd commented Jun 25, 2025

Uh oh!

jeffdaily commented Jun 26, 2025

Uh oh!

pytorchmergebot commented Jun 26, 2025

Uh oh!

pytorchmergebot commented Jun 26, 2025

Uh oh!

jeffdaily commented Jun 27, 2025

Uh oh!

pytorchmergebot commented Jun 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[ROCm][Windows] Fixing undefined symbol linker error after exposing MIOpen symbols #156479

[ROCm][Windows] Fixing undefined symbol linker error after exposing MIOpen symbols #156479

Uh oh!

Conversation

tvukovic-amd commented Jun 20, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156479

❗ 1 Active SEVs

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

tvukovic-amd commented Jun 20, 2025

Uh oh!

jeffdaily commented Jun 23, 2025

Uh oh!

tvukovic-amd commented Jun 24, 2025

Uh oh!

jeffdaily left a comment

Choose a reason for hiding this comment

Uh oh!

tvukovic-amd commented Jun 25, 2025

Uh oh!

jeffdaily commented Jun 26, 2025

Uh oh!

pytorchmergebot commented Jun 26, 2025

Uh oh!

pytorchmergebot commented Jun 26, 2025

Uh oh!

jeffdaily commented Jun 27, 2025

Uh oh!

pytorchmergebot commented Jun 27, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tvukovic-amd commented Jun 20, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jun 20, 2025 •

edited

Loading