KEMBAR78
[dynamo] fix segfault due to dangling CacheEntry backend pointer by williamwen42 · Pull Request #156527 · pytorch/pytorch · GitHub
Skip to content

[dynamo] fix segfault due to dangling CacheEntry backend pointer #156527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[dynamo] fix segfault due to dangling CacheEntry backend pointer #156527

wants to merge 5 commits into from

Conversation

@williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Jun 21, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156527

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ 2 Pending, 1 Unrelated Failure

As of commit ce347d2 with merge base 9fe2d15 (image):

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@williamwen42 williamwen42 added the topic: bug fixes topic category label Jun 21, 2025
@williamwen42
Update on "[dynamo] fix segfault due to dangling CacheEntry backend p…
041ca52 
…ointer"


Fixes #155057

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Jun 21, 2025
@williamwen42
[dynamo] fix segfault due to dangling CacheEntry backend pointer
9fd1afb 
ghstack-source-id: 03e7f69
Pull Request resolved: #156527
@williamwen42
Copy link
Member Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/williamwen42/251/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging test/dynamo/test_repros.py
CONFLICT (content): Merge conflict in test/dynamo/test_repros.py
Auto-merging torch/csrc/dynamo/extra_state.cpp
error: could not apply 9fd1afbd814... [dynamo] fix segfault due to dangling CacheEntry backend pointer
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 9fd1afbd814... [dynamo] fix segfault due to dangling CacheEntry backend pointer

Raised by https://github.com/pytorch/pytorch/actions/runs/15802698052

@williamwen42
Update on "[dynamo] fix segfault due to dangling CacheEntry backend p…
35a2c89 
…ointer"


Fixes #155057

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Jun 23, 2025
@williamwen42
[dynamo] fix segfault due to dangling CacheEntry backend pointer
194b2dd 
ghstack-source-id: ab13998
Pull Request resolved: #156527
@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@williamwen42
Copy link
Member Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #156527, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@williamwen42
Copy link
Member Author

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/main gh/williamwen42/251/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging test/dynamo/test_repros.py
CONFLICT (content): Merge conflict in test/dynamo/test_repros.py
error: could not apply 048d959ad6f... [dynamo] fix segfault due to dangling CacheEntry backend pointer
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 048d959ad6f... [dynamo] fix segfault due to dangling CacheEntry backend pointer

Raised by https://github.com/pytorch/pytorch/actions/runs/15834520748

@williamwen42
Update on "[dynamo] fix segfault due to dangling CacheEntry backend p…
a8062d6 
…ointer"


Fixes #155057

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Jun 23, 2025
@williamwen42
[dynamo] fix segfault due to dangling CacheEntry backend pointer
5e19f4f 
ghstack-source-id: 5d5c623
Pull Request resolved: #156527
@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@williamwen42 williamwen42 mentioned this pull request Jun 25, 2025
Closed
@Camyll
Copy link
Contributor

Camyll commented Jun 26, 2025

@pytorchbot revert -m='failing test assertions' -c=ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jun 26, 2025
@pytorchmergebot
Revert "[dynamo] fix segfault due to dangling CacheEntry backend poin…
9fe2d15 
…ter (#156527)"

This reverts commit 5ad2bee.

Reverted #156527 on behalf of https://github.com/Camyll due to failing test assertions ([comment](#156527 (comment)))
@pytorchmergebot
Copy link
Collaborator

@williamwen42 your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jun 26, 2025
@williamwen42
Update on "[dynamo] fix segfault due to dangling CacheEntry backend p…
ce347d2 
…ointer"


Fixes #155057

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
williamwen42 added a commit that referenced this pull request Jun 26, 2025
@williamwen42
[dynamo] fix segfault due to dangling CacheEntry backend pointer
ee55261 
ghstack-source-id: 261f90d
Pull Request resolved: #156527
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #156901

pytorchmergebot pushed a commit that referenced this pull request Jun 26, 2025
@williamwen42 @pytorchmergebot
[dynamo] fix _torchdynamo_orig_callable naming issues (#156901)
eb9efb3 
`_torchdynamo_orig_callable` was being used in two distinct places:
- to get the original user function from nested eval_frame.py decorators
- to get the original backend from nested convert_frame.py callbacks

We rename the first usage to `_torchdynamo_orig_fn` and the second to `_torchdynamo_orig_backend` in order to distinguish these cases.

Pull Request resolved: #156901
Approved by: https://github.com/StrongerXi, https://github.com/jansel
ghstack dependencies: #156527
@github-actions github-actions bot deleted the gh/williamwen42/251/head branch July 27, 2025 02:22
@lingebeng lingebeng mentioned this pull request Oct 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@anijain2305 anijain2305 anijain2305 approved these changes

@StrongerXi StrongerXi Awaiting requested review from StrongerXi

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: dynamo Reverted topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@williamwen42 @pytorchmergebot @Camyll @jansel @anijain2305