[AOTI][Intel GPU] Add XPU quantization ops to AOT Inductor. #156572
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156572
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d878b74 with merge base be16122 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: cpu
etaf
changed the title
Attention! PyTorch one of the C-stable API file was changedYou MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function. Caused by: |
…uctor." cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
…uctor." cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
…uctor." cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
…uctor." cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
…uctor." cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
etaf
changed the title
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
oh, thanks. I prefer to keep the current file structure so as to aggregate the XPU oneDNN integrations in single directory. Currently, it is clean and easy to maintain. CPU-side need to add onednn-only operators like |
There was a problem hiding this comment.
@chuanqi129 , regarding this file, pls. help review it.
| --shard "$1" "$NUM_TEST_SHARDS" \ | ||
| --verbose | ||
|
|
||
| if [[ "${BUILD_ENVIRONMENT}" == *xpu* ]]; then |
There was a problem hiding this comment.
Why we need add this test into function test_inductor_cpp_wrapper_shard()? This function only be tested with test config inductor_cpp_wrapper. We only use default test config in xpu test, could you please double confirm that those new test cases whether be tested with xpu ci job?
There was a problem hiding this comment.
No, but the reviewer asked us to add new test cases here.
|
@desertfire Could you please kindly help review the stacked two PRs when convenient? |
|
@angelayi Could you please review it? |
|
@pytorchbot rebase |
xuhancn
added
the
ciflow/binaries
|
@pytorchmergebot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
| -k 'xpu' \ | ||
| --shard "$1" "$NUM_TEST_SHARDS" \ | ||
| --verbose | ||
| fi |
There was a problem hiding this comment.
I'm unsure about this change but seems like CI is picking it up so looks ok?
cc @huydhn if you have more input 😅
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…156572) Pull Request resolved: pytorch#156572 Approved by: https://github.com/EikanWang, https://github.com/angelayi ghstack dependencies: pytorch#157430
10 participants
Stack from ghstack (oldest at bottom):
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben