KEMBAR78
chunk_size should always be int64_t for Foreach functors by janeyx99 · Pull Request #156872 · pytorch/pytorch · GitHub
Skip to content

chunk_size should always be int64_t for Foreach functors #156872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

chunk_size should always be int64_t for Foreach functors #156872

wants to merge 3 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jun 25, 2025 •
edited
Loading

@janeyx99 janeyx99 requested review from eqy and syed-ahmed as code owners June 25, 2025 19:40
@janeyx99 janeyx99 mentioned this pull request Jun 25, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156872

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4414075 with merge base 070aa59 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: foreach_frontend release notes category label Jun 25, 2025
janeyx99 added a commit that referenced this pull request Jun 25, 2025
@janeyx99
chunk_size should always be int64_t for Foreach functors
4ae3f02 
ghstack-source-id: dbe26ec
Pull Request resolved: #156872
@janeyx99 janeyx99 added the topic: bug fixes topic category label Jun 25, 2025
@janeyx99 janeyx99 mentioned this pull request Jun 25, 2025
Closed
@janeyx99 janeyx99 requested review from albanD and ngimel June 25, 2025 19:46
@ngimel
Copy link
Collaborator

ngimel commented Jun 25, 2025

I'm not sure if all foreach functors strictly require this, but probably it doesn't hurt.

@janeyx99 janeyx99 mentioned this pull request Jun 25, 2025
Closed
@janeyx99
Update on "chunk_size should always be int64_t for Foreach functors"
2d41243 
See #156261 (comment)

Testing is a valid q--it is pretty expensive to test such large tensors for all these ops.




[ghstack-poisoned]
janeyx99 added a commit that referenced this pull request Jun 25, 2025
@janeyx99
chunk_size should always be int64_t for Foreach functors
5e7d7db 
ghstack-source-id: 5dbe73f
Pull Request resolved: #156872
albanD
albanD reviewed Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're not changing any caller into these operators? Does that mean that we used to have a warning somewhere that we were narrowing the argument we ignored?

@janeyx99
Update on "chunk_size should always be int64_t for Foreach functors"
4414075 
See #156261 (comment)

Testing is a valid q--it is pretty expensive to test such large tensors for all these ops.




[ghstack-poisoned]
janeyx99 added a commit that referenced this pull request Jun 27, 2025
@janeyx99
chunk_size should always be int64_t for Foreach functors
3a1fd52 
ghstack-source-id: 763d409
Pull Request resolved: #156872
@janeyx99
Copy link
Contributor Author

I see you're not changing any caller into these operators? Does that mean that we used to have a warning somewhere that we were narrowing the argument we ignored?

We don't have a warning, but these functors are called here, where kChunkSize is an int64_t: https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/cuda/MultiTensorApply.cuh#L106

@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchbot pytorchbot mentioned this pull request Jul 22, 2025
Merged
@github-actions github-actions bot deleted the gh/janeyx99/273/head branch July 28, 2025 02:21
@lingebeng lingebeng mentioned this pull request Oct 21, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 21, 2025
@lingebeng @pytorchmergebot
[BugFix] chunk_size should always be int64_t (#165971)
1c7fe8f 
aspired by #156872
Pull Request resolved: #165971
Approved by: https://github.com/albanD
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
@lingebeng @zhudada0120
[BugFix] chunk_size should always be int64_t (pytorch#165971)
3b0eaa7 
aspired by pytorch#156872
Pull Request resolved: pytorch#165971
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD left review comments

@Skylion007 Skylion007 Skylion007 approved these changes

@eqy eqy eqy approved these changes

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: foreach_frontend release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@janeyx99 @ngimel @pytorchmergebot @Skylion007 @eqy @albanD