Move isnan to C++ #15722
Closed
Move isnan to C++ #15722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
approved these changes
Jan 4, 2019
There was a problem hiding this comment.
@goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jan 8, 2019
Summary: Wanted to use `Tensor.isnan` in C++, figured it'd be nice to have, so I made it into a tiny native function. gchanan ezyang apaszke Pull Request resolved: pytorch/pytorch#15722 Differential Revision: D13591315 Pulled By: goldsborough fbshipit-source-id: a78bd22101fde87a0257f759b9bfcf3b4208f5fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to use
Tensor.isnanin C++, figured it'd be nice to have, so I made it into a tiny native function.@gchanan @ezyang @apaszke