-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[DeviceMesh] Use user set backend and pg option even for the global mesh #157501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157501
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 059335f with merge base ccb67f3 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, do we have a test for this feature?
|
Starting merge as part of PR stack under #157523 |
|
@fegin I will add one test in a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This should fix my issue!
…ed dim submesh (#157523) With #157393, we want to first throw a clearer error for users and then fix it in the long-term Pull Request resolved: #157523 Approved by: https://github.com/fegin ghstack dependencies: #157501
Stack from ghstack (oldest at bottom):
Short term solution to #156593.
cc @H-Huang @awgu @wanchaol @fegin @wz337 @wconstab @d4l3k