KEMBAR78
[inductor] re-enable TMA templates w/ AOTI by davidberard98 · Pull Request #157819 · pytorch/pytorch · GitHub
Skip to content

[inductor] re-enable TMA templates w/ AOTI #157819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[inductor] re-enable TMA templates w/ AOTI #157819

wants to merge 2 commits into from

Conversation

@davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Jul 8, 2025 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Follow-up from #155896: now that AOTI can codegen non-null TMA workspace args, we can re-enable TMA templates w/ AOTI.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157819

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b2c0df8 with merge base e3f2597 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

davidberard98 added a commit that referenced this pull request Jul 8, 2025
@davidberard98
[inductor] re-enable TMA w/ AOTI
25ebfe4 
ghstack-source-id: 836a738
Pull Request resolved: #157819
@davidberard98 davidberard98 changed the title [inductor] re-enable TMA w/ AOTI [inductor] re-enable TMA templates w/ AOTI Jul 8, 2025
@davidberard98
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@davidberard98
Update
b2c0df8 
[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jul 9, 2025
@davidberard98
[inductor] re-enable TMA w/ AOTI
c13a346 
ghstack-source-id: 3ad7301
Pull Request resolved: #157819
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/davidberard98/387/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/157819)

@davidberard98 davidberard98 marked this pull request as ready for review July 9, 2025 15:30
drisspg
drisspg approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there already a test for this?

@davidberard98
Copy link
Contributor Author

@drisspg this should test it:

TORCHINDUCTOR_CPP_WRAPPER=1 python test/inductor/test_max_autotune.py -k tma

(note: this doesn't run in CI yet, but I verified locally)

@davidberard98
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 10, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/davidberard98/387/head branch August 10, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drisspg drisspg drisspg approved these changes

@mandroid6 mandroid6 Awaiting requested review from mandroid6

@NikhilAPatel NikhilAPatel Awaiting requested review from NikhilAPatel

Assignees

No one assigned

Labels

ciflow/h100 ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor (aoti)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidberard98 @pytorchmergebot @drisspg