[MPS] Avoid calling tensor ops in max_pool3d impl #157874
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157874
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Cancelled JobsAs of commit afa525f with merge base 317520b ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
This was referenced Jul 9, 2025
kurtamohler
added a commit
to kurtamohler/pytorch
that referenced
this pull request
Jul 9, 2025
ghstack-source-id: 84d2d04 Pull-Request: pytorch#157874
malfet
approved these changes
Jul 9, 2025
kurtamohler
added a commit
to kurtamohler/pytorch
that referenced
this pull request
Jul 9, 2025
ghstack-source-id: e46fed2 Pull-Request: pytorch#157874
|
Thanks for the review, I've made those changes |
|
@pytorchbot merge -f "Lint + MPS are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
stride != 1#157876