KEMBAR78
Fix from_node's graph_id in unlift() by yushangdi · Pull Request #157943 · pytorch/pytorch · GitHub
Skip to content

Fix from_node's graph_id in unlift() #157943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix from_node's graph_id in unlift() #157943

wants to merge 1 commit into from

Conversation

@yushangdi
Copy link
Contributor

Summary: We should use the node before deepcopy in NodeSource

Test Plan:

buck run fbcode//caffe2/test:test_export -- -r test_from_node_metadata_export

Rollback Plan:

Differential Revision: D78022070

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157943

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8c947ea with merge base 317520b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78022070

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 9, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78022070

@yushangdi @facebook-github-bot
Fix from_node's graph_id in unlift() (pytorch#157943)
8c947ea 
Summary:

We should use the node before deepcopy in NodeSource

Test Plan:
```
buck run fbcode//caffe2/test:test_export -- -r test_from_node_metadata_export

buck run fbcode//caffe2/test:test_export -- -r test_none_buffers
```

Gasoonjia: N7262964 tested three different scenenrio: unlifted module, operator decomposition, and reexporte module. All three cases meets expectation!

Rollback Plan:

Reviewed By: Gasoonjia

Differential Revision: D78022070
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78022070

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@Gasoonjia Gasoonjia Gasoonjia approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: export

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yushangdi @facebook-github-bot @pytorchmergebot @angelayi @Gasoonjia