-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Fix DTensor handling of conjugate bit. #158030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158030
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 248a71a with merge base aab949a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Fixes #130646 specifically for DTensor Fixes pytorch/torchtitan#267 Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 5b5124e Pull-Request: #158030
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, needs a test? I see them in the following PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@pytorchbot merge -f "Low ROCm risk" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #158033 Approved by: https://github.com/bdhirsh, https://github.com/albanD ghstack dependencies: #158030
Stack from ghstack (oldest at bottom):
Fixes #130646 specifically for DTensor
Fixes pytorch/torchtitan#267
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k