KEMBAR78
Fix DTensor handling of conjugate bit. by ezyang · Pull Request #158030 · pytorch/pytorch · GitHub
Skip to content

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jul 10, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158030

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 248a71a with merge base aab949a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Jul 10, 2025
ezyang added a commit that referenced this pull request Jul 10, 2025
Fixes #130646 specifically for DTensor

Fixes pytorch/torchtitan#267

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
ghstack-source-id: 5b5124e
Pull-Request: #158030
@ezyang ezyang requested a review from tianyu-l July 10, 2025 15:20
@ezyang ezyang added topic: bug fixes topic category release notes: distributed (dtensor) release notes category labels Jul 10, 2025
ezyang added a commit that referenced this pull request Jul 10, 2025
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
ghstack-source-id: ab9957e
Pull-Request: #158033
Copy link
Contributor

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs a test? I see them in the following PR

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ezyang
Copy link
Contributor Author

ezyang commented Jul 10, 2025

@pytorchbot merge -f "Low ROCm risk"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jul 10, 2025
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #158033
Approved by: https://github.com/bdhirsh, https://github.com/albanD
ghstack dependencies: #158030
@github-actions github-actions bot deleted the gh/ezyang/3094/head branch August 10, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (dtensor) release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants