KEMBAR78
Add cudaMallocAsync/cudaFreeAsync to cuda_to_hip_mappings by fnz · Pull Request #158056 · pytorch/pytorch · GitHub
Skip to content

Add cudaMallocAsync/cudaFreeAsync to cuda_to_hip_mappings #158056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add cudaMallocAsync/cudaFreeAsync to cuda_to_hip_mappings #158056

wants to merge 1 commit into from

Conversation

@fnz
Copy link
Contributor

@fnz fnz commented Jul 10, 2025 •
edited
Loading

Summary: Adding both functions as they're required for Hipification of https://fburl.com/code/165r7qhr

Test Plan:
Tested in D78090513

Rollback Plan:

Reviewed By: malfet, jiangyurong609

Differential Revision: D78090693

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2025

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @fnz, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158056

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 087a8ac with merge base 8c5b070 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78090693

@fnz fnz force-pushed the export-D78090693 branch from 6cccb2e to 3d34e8c Compare July 10, 2025 19:19
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78090693

@fnz fnz force-pushed the export-D78090693 branch from 3d34e8c to 7a32d6a Compare July 10, 2025 19:32
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78090693

@fnz fnz force-pushed the export-D78090693 branch from 7a32d6a to c26e137 Compare July 10, 2025 19:40
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78090693

@fnz
Copy link
Contributor Author

fnz commented Jul 10, 2025

@pytorchbot label "release notes: rocm"

@pytorch-bot pytorch-bot bot added the release notes: rocm mandatorylabel label Jul 10, 2025
@fnz fnz force-pushed the export-D78090693 branch from c26e137 to 51f0863 Compare July 10, 2025 19:51
@fnz @facebook-github-bot
Add cudaMallocAsync/cudaFreeAsync to cuda_to_hip_mappings (pytorch#15…
087a8ac 
…8056)

Summary:
Pull Request resolved: pytorch#158056

release notes: cudaMallocAsync/cudaFreeAsync added to cuda_to_hip_mappings

Test Plan:
Tested in D78090513

Rollback Plan:

Reviewed By: malfet, jiangyurong609

Differential Revision: D78090693
@fnz fnz force-pushed the export-D78090693 branch from 51f0863 to 087a8ac Compare July 10, 2025 19:59
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78090693

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 11, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable), pull / linux-jammy-cuda12.8-py3.10-gcc11-sm89 / test (default, 4, 5, linux.g6.4xlarge.experimental.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: rocm mandatorylabel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fnz @facebook-github-bot @pytorchmergebot @Skylion007