KEMBAR78
[DTensor] Rewrite doc of TupleStrategy by wconstab · Pull Request #158132 · pytorch/pytorch · GitHub
Skip to content

[DTensor] Rewrite doc of TupleStrategy #158132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[DTensor] Rewrite doc of TupleStrategy #158132

wants to merge 3 commits into from

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Jul 11, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158132

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Cancelled Jobs, 1 Unrelated Failure

As of commit a7839d6 with merge base b4476ca (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Jul 11, 2025
@wconstab
Update on "[DTensor] Rewrite doc of TupleStrategy"
f1ed390 
cc H-Huang awgu wanchaol fegin fduwjj wz337 d4l3k

[ghstack-poisoned]
This was referenced Jul 11, 2025
Open
Closed
XilunWu
XilunWu approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@XilunWu XilunWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I agree with this explanation:
TupleStrategy corresponds to the case where each output is the computation result of a subset of inputs, and those subsets are non-overlapped. That being said, the sharding decisions of those subsets are independent.

@wconstab
Update on "[DTensor] Rewrite doc of TupleStrategy"
a7839d6 
cc H-Huang awgu wanchaol fegin fduwjj wz337 d4l3k

[ghstack-poisoned]
@wconstab wconstab added the release notes: distributed (dtensor) release notes category label Jul 11, 2025
@wconstab
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 11, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 jobs have failed, first few of them are: inductor / unit-test / cuda12.8-py3.12-gcc9-sm86 / build, inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / build, inductor / linux-jammy-cpu-py3.9-gcc11-inductor / build

Details for Dev Infra team Raised by workflow job

@wconstab
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 4 checks: inductor / unit-test / cuda12.8-py3.12-gcc9-sm86 / build, inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / build, inductor / linux-jammy-cpu-py3.9-gcc11-inductor / build, pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zpcore
zpcore reviewed Jul 11, 2025
View reviewed changes
pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2025
@wconstab @pytorchmergebot
[DTensor] Assert DTensorSpec has valid placements (#158133)
1839e8d 
This helped identify buggy sharding rules during debugging, why not
check it in.

Pull Request resolved: #158133
Approved by: https://github.com/XilunWu, https://github.com/zpcore
ghstack dependencies: #158132
facebook-github-bot pushed a commit that referenced this pull request Jul 24, 2025
@wconstab @facebook-github-bot
[DTensor] Assert DTensorSpec has valid placements (#158133) (#158133)
226e35c 
Summary:
This helped identify buggy sharding rules during debugging, why not
check it in.

Approved by: https://github.com/XilunWu, https://github.com/zpcore
ghstack dependencies: #158132

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1839e8d04b81ee6eda0cff6fbfc218a7a600f6f7

Rollback Plan:

Differential Revision: D78929245
@wconstab wconstab mentioned this pull request Jul 24, 2025
Closed
@github-actions github-actions bot deleted the gh/wconstab/423/head branch August 11, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zpcore zpcore zpcore left review comments

@XilunWu XilunWu XilunWu approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (dtensor) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wconstab @pytorchmergebot @zpcore @XilunWu