KEMBAR78
Add STD_TORCH_CHECK to headeronly by janeyx99 · Pull Request #158377 · pytorch/pytorch · GitHub
Skip to content

Add STD_TORCH_CHECK to headeronly #158377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add STD_TORCH_CHECK to headeronly #158377

wants to merge 4 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jul 15, 2025 •
edited
Loading

This was referenced Jul 15, 2025
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158377

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 53 Pending

As of commit 9e696a5 with merge base 0eae6b6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Jul 15, 2025
@janeyx99
Add STD_TORCH_CHECK to headeronly
bebba35 
Differential Revision: [D78366519](https://our.internmc.facebook.com/intern/diff/D78366519/)

ghstack-source-id: 296398023
Pull Request resolved: #158377
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78366519

@janeyx99 janeyx99 added the release notes: build release notes category label Jul 15, 2025
janeyx99 added a commit that referenced this pull request Jul 16, 2025
@janeyx99
Add STD_TORCH_CHECK to headeronly
87c4f0a 
Pull Request resolved: #158377

Differential Revision: [D78366519](https://our.internmc.facebook.com/intern/diff/D78366519/)
ghstack-source-id: 296560399
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78366519

@janeyx99 janeyx99 added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 16, 2025
@janeyx99 janeyx99 mentioned this pull request Jul 16, 2025
Closed
@janeyx99 janeyx99 requested review from albanD and swolchok July 16, 2025 17:43
albanD
albanD approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

janeyx99 added a commit that referenced this pull request Jul 16, 2025
@janeyx99
Add STD_TORCH_CHECK to headeronly
8a98be7 
Pull Request resolved: #158377


ghstack-source-id: 296617022

Differential Revision: [D78366519](https://our.internmc.facebook.com/intern/diff/D78366519/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78366519

This was referenced Jul 17, 2025
Closed
Closed
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-docs / build-docs-functorch-false, pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 8a98be7128d55f4cfe4c9168155c10781fb57ddb returned non-zero exit code 1

Auto-merging test/cpp_extensions/libtorch_agnostic_extension/libtorch_agnostic/csrc/kernel.cpp
CONFLICT (content): Merge conflict in test/cpp_extensions/libtorch_agnostic_extension/libtorch_agnostic/csrc/kernel.cpp
error: could not apply 8a98be7128d... Add STD_TORCH_CHECK to headeronly
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@pytorch-bot pytorch-bot bot added ciflow/h100-symm-mem ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/mps Run MPS tests (subset of trunk) module: amp (automated mixed precision) autocast module: compiled autograd compiled_autograd module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration NNC oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: quantization release notes category release notes: distributed (checkpoint) release notes: inductor (aoti) labels Jul 18, 2025
@wdvr wdvr force-pushed the gh/janeyx99/278/head branch from 7372545 to 2a555ec Compare July 18, 2025 03:42
@janeyx99
Update on "Add STD_TORCH_CHECK to headeronly"
9e696a5 
Differential Revision: [D78366519](https://our.internmc.facebook.com/intern/diff/D78366519/)

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 jerryzh168 gujinghui PenghuiCheng jianyuh min-jean-cho yanbing-j Guobing-Chen Xia-Weiwen snadampal mcarilli ptrblck leslie-fang-intel EikanWang voznesenskym penguinwu zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela xmfan

[ghstack-poisoned]
janeyx99 added a commit that referenced this pull request Jul 18, 2025
@janeyx99
Add STD_TORCH_CHECK to headeronly
9755197 
Pull Request resolved: #158377

ghstack-source-id: 3d882bb

Differential Revision: [D78366519](https://our.internmc.facebook.com/intern/diff/D78366519/)
@janeyx99
Copy link
Contributor Author

@pytorchbot merge -f "This already passed all signals before and just got rebased, merging asap to close the gap between when this PR was merged internally and externally"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@janeyx99 janeyx99 mentioned this pull request Jul 21, 2025
Open
51 tasks
@github-actions github-actions bot deleted the gh/janeyx99/278/head branch August 18, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@swolchok swolchok Awaiting requested review from swolchok

@eqy eqy Awaiting requested review from eqy

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@angelayi angelayi Awaiting requested review from angelayi

@EikanWang EikanWang Awaiting requested review from EikanWang

@gujinghui gujinghui Awaiting requested review from gujinghui

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

@divyanshk divyanshk Awaiting requested review from divyanshk

@ramanishsingh ramanishsingh Awaiting requested review from ramanishsingh

@ezyang ezyang Awaiting requested review from ezyang

@Chillee Chillee Awaiting requested review from Chillee

@sraikund16 sraikund16 Awaiting requested review from sraikund16

@kulinseth kulinseth Awaiting requested review from kulinseth

@malfet malfet Awaiting requested review from malfet

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@zou3519 zou3519 Awaiting requested review from zou3519

@kshitij12345 kshitij12345 Awaiting requested review from kshitij12345

@lezcano lezcano Awaiting requested review from lezcano

@nikitaved nikitaved Awaiting requested review from nikitaved

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk

@desertfire desertfire Awaiting requested review from desertfire

@eellison eellison Awaiting requested review from eellison

@shunting314 shunting314 Awaiting requested review from shunting314

@bertmaher bertmaher Awaiting requested review from bertmaher

@jataylo jataylo Awaiting requested review from jataylo

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

@HDCharles HDCharles Awaiting requested review from HDCharles

@salilsdesai salilsdesai Awaiting requested review from salilsdesai

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

@digantdesai digantdesai Awaiting requested review from digantdesai

@jianyuh jianyuh Awaiting requested review from jianyuh

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

ciflow/h100-symm-mem ciflow/inductor ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: amp (automated mixed precision) autocast module: compiled autograd compiled_autograd module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration NNC oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: build release notes category release notes: distributed (checkpoint) release notes: inductor (aoti) release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janeyx99 @facebook-github-bot @pytorchmergebot @albanD