Fix log_prob for Gumbel distribution #15878
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase to fix macos builds :) |
fritzo
approved these changes
Jan 9, 2019
…el-log_prob-fix
soumith
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vishwakftw
added a commit
to vishwakftw/pytorch
that referenced
this pull request
Jan 18, 2019
Summary: Fixes pytorch#15681 Changelog: - Add hard-coded implementation of log_prob Pull Request resolved: pytorch#15878 Differential Revision: D13613716 Pulled By: soumith fbshipit-source-id: 2ba74e52748b6213098b167940dcc068f0c056f4
soumith
pushed a commit
that referenced
this pull request
Jan 18, 2019
soumith
pushed a commit
that referenced
this pull request
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15681
Changelog:
Test plan:
cc: @fritzo
There seems to be a precision issue (reported above) in the Gumbel
log_probfunction computed using the transforms, which is why I have hard-coded it.