KEMBAR78
[MPS] Enable dlpack integration by malfet · Pull Request #158888 · pytorch/pytorch · GitHub
Skip to content

[MPS] Enable dlpack integration #158888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Enable dlpack integration #158888

wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jul 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Though testing is a lie and dependent on #153835

Fixes #153789

@malfet
Update
16fcd07 
[ghstack-poisoned]
@malfet malfet mentioned this pull request Jul 22, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158888

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b6aa1ae with merge base ddd74d1 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Jul 22, 2025
@malfet
[MPS] Enable dlpack integration
a070660 
Though testing is a lie and dependent on #153835

Fixes #153789

ghstack-source-id: 13447a4
Pull Request resolved: #158888
@malfet malfet added the topic: not user facing topic category label Jul 23, 2025
@malfet malfet requested a review from albanD July 23, 2025 04:22
@malfet
Update
b6aa1ae 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Jul 23, 2025
@malfet
[MPS] Enable dlpack integration
6eff078 
Though testing is a lie and dependent on #153835

Fixes #153789

ghstack-source-id: 622e5a4
Pull Request resolved: #158888
albanD
albanD approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Any synchronization logic that needs adding similar to https://github.com/pytorch/pytorch/blob/main/torch/utils/dlpack.py#L144-L155 ?

@malfet
Copy link
Contributor Author

malfet commented Jul 24, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 24, 2025
@malfet
Copy link
Contributor Author

malfet commented Jul 24, 2025

Nice! Any synchronization logic that needs adding similar to https://github.com/pytorch/pytorch/blob/main/torch/utils/dlpack.py#L144-L155 ?

Nope, as we don't expose concept of threads in MPS/Metal yet

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@malfet @yangw-dev
[MPS] Enable dlpack integration (#158888)
f762f99 
Though testing is a lie and dependent on #153835

Fixes #153789
Pull Request resolved: #158888
Approved by: https://github.com/albanD
ghstack dependencies: #158874
@github-actions github-actions bot deleted the gh/malfet/446/head branch August 24, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @albanD