KEMBAR78
[CI] Add smoke test for NVSHMEM availability by kwen2501 · Pull Request #158938 · pytorch/pytorch · GitHub
Skip to content

[CI] Add smoke test for NVSHMEM availability #158938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[CI] Add smoke test for NVSHMEM availability #158938

wants to merge 4 commits into from

Conversation

@kwen2501
Copy link
Contributor

@kwen2501 kwen2501 commented Jul 23, 2025 •
edited
Loading

@kwen2501
Update
e4b7075 
[ghstack-poisoned]
@kwen2501 kwen2501 requested a review from a team as a code owner July 23, 2025 18:21
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158938

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 376c425 with merge base fef236d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kwen2501 added a commit that referenced this pull request Jul 23, 2025
@kwen2501
[CI] Add smoke test for NVSHMEM availability
569f2bc 
ghstack-source-id: 2eb7105
Pull-Request-resolved: #158938
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 23, 2025
huydhn
huydhn approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

huydhn
huydhn reviewed Jul 23, 2025
View reviewed changes
.ci/pytorch/smoke_test/smoke_test.py Outdated
print("torch not compiled with NVSHMEM")
return
# 2.9 behavior: NVSHMEM is expected to be compiled in current build
# raise RuntimeError("torch not compiled with NVSHMEM")
Copy link
Contributor

@huydhn huydhn Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could write this logic in a future proof way by checking for torch.__version__ to raise a runtime error if the version is >= 2.9. Otherwise, I assume someone would need to remember to update this before 2.9 release

https://github.com/pytorch/pytorch/blob/main/torch/torch_version.py

atalman
atalman approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think suggestion from @huydhn is good if version is 2.8.0 or less we expect torch not to be compled with NVSHMEM and raise exception if its available for version 2.9.0 raise exception if CUDA is available but not nvshmem

@kwen2501
Update
89411e5 
[ghstack-poisoned]
kwen2501 added a commit that referenced this pull request Jul 23, 2025
@kwen2501
[CI] Add smoke test for NVSHMEM availability
6ca2b09 
ghstack-source-id: 5b0b130
Pull-Request-resolved: #158938
@kwen2501
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kwen2501
Update
87a5be4 
[ghstack-poisoned]
kwen2501 added a commit that referenced this pull request Jul 23, 2025
@kwen2501
[CI] Add smoke test for NVSHMEM availability
bce8057 
ghstack-source-id: 54cc8aa
Pull-Request-resolved: #158938
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@kwen2501
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@huydhn
Copy link
Contributor

huydhn commented Jul 24, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@kwen2501
Update
376c425 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/kwen2501/197/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/158938)

pytorchmergebot pushed a commit that referenced this pull request Jul 24, 2025
@kwen2501
[CI] Add smoke test for NVSHMEM availability
fa047de 
ghstack-source-id: a60fad9
Pull-Request-resolved: #158938
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@kwen2501 @yangw-dev
[CI] Add smoke test for NVSHMEM availability (#158938)
c017c18 
Pull Request resolved: #158938
Approved by: https://github.com/huydhn, https://github.com/atalman
@github-actions github-actions bot deleted the gh/kwen2501/197/head branch August 24, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kwen2501 @pytorchmergebot @huydhn @atalman