-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[doc] remove FSDP1 developer note #158991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158991
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit b8c9139 with merge base 86df3ff ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
this resolve pytorch doc audit - we remove fsdp1 doc and promote fsdp2 https://docs.pytorch.org/tutorials/intermediate/FSDP_tutorial.html ghstack-source-id: 2419b33 Pull-Request: #158991
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, LGTM
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Also, some new frameworks continue to also use FSDP1 (e.g. Verl), might be good to have this note still published somewhere (even if not advertised) - maybe in main FSDP1 docs?.. |
good suggestion! I can keep a copy of the doc in pytorch/tutorials. people can access 3 fsdp1 docs from https://docs.pytorch.org/tutorials/intermediate/FSDP_tutorial.html
|
this resolve pytorch doc audit - we remove fsdp1 doc and promote fsdp2 https://docs.pytorch.org/tutorials/intermediate/FSDP_tutorial.html Pull Request resolved: #158991 Approved by: https://github.com/svekars, https://github.com/mori360 ghstack dependencies: #158989

Stack from ghstack (oldest at bottom):
this resolve pytorch doc audit - we remove fsdp1 doc and promote fsdp2
https://docs.pytorch.org/tutorials/intermediate/FSDP_tutorial.html
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta