KEMBAR78
[doc] remove FSDP1 developer note by weifengpy · Pull Request #158991 · pytorch/pytorch · GitHub
Skip to content

Conversation

@weifengpy
Copy link
Contributor

@weifengpy weifengpy commented Jul 23, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158991

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit b8c9139 with merge base 86df3ff (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

weifengpy added a commit that referenced this pull request Jul 23, 2025
this resolve pytorch doc audit - we remove fsdp1 doc and promote fsdp2

https://docs.pytorch.org/tutorials/intermediate/FSDP_tutorial.html
ghstack-source-id: 2419b33
Pull-Request: #158991
@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (sharded) release notes category labels Jul 23, 2025
@weifengpy weifengpy requested review from mori360 and svekars July 23, 2025 23:23
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mori360 mori360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM

@weifengpy
Copy link
Contributor Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 24, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@vadimkantorov
Copy link
Contributor

Also, some new frameworks continue to also use FSDP1 (e.g. Verl), might be good to have this note still published somewhere (even if not advertised) - maybe in main FSDP1 docs?..

@weifengpy
Copy link
Contributor Author

Also, some new frameworks continue to also use FSDP1 (e.g. Verl), might be good to have this note still published somewhere (even if not advertised) - maybe in main FSDP1 docs?..

good suggestion! I can keep a copy of the doc in pytorch/tutorials. people can access 3 fsdp1 docs from https://docs.pytorch.org/tutorials/intermediate/FSDP_tutorial.html

Screenshot 2025-07-24 at 12 40 12

yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
this resolve pytorch doc audit - we remove fsdp1 doc and promote fsdp2

https://docs.pytorch.org/tutorials/intermediate/FSDP_tutorial.html

Pull Request resolved: #158991
Approved by: https://github.com/svekars, https://github.com/mori360
ghstack dependencies: #158989
@github-actions github-actions bot deleted the gh/weifengpy/32/head branch August 24, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (sharded) release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants