[C++ Frontend] Fix bug in torch::load and unpack torch::optim::detail namespace #15926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Jan 10, 2019
soumith
added
the
cherry-picked
soumith
pushed a commit
that referenced
this pull request
Jan 18, 2019
) Summary: Wasn't clearing optimizer buffers before adding new entries to it during deserialization. Successive calls to `torch::load` with the same optimizer would just append to the buffer container. Also moved `serialize()` function from `torch::optim::detail` into `torch::optim` so users can use it for custom optimizers. Fixes #15792 ezyang Pull Request resolved: #15926 Differential Revision: D13623615 Pulled By: goldsborough fbshipit-source-id: e193091f25f56a95f2a9648af312cb7caa45f300
soumith
pushed a commit
that referenced
this pull request
Jan 29, 2019
) Summary: Wasn't clearing optimizer buffers before adding new entries to it during deserialization. Successive calls to `torch::load` with the same optimizer would just append to the buffer container. Also moved `serialize()` function from `torch::optim::detail` into `torch::optim` so users can use it for custom optimizers. Fixes #15792 ezyang Pull Request resolved: #15926 Differential Revision: D13623615 Pulled By: goldsborough fbshipit-source-id: e193091f25f56a95f2a9648af312cb7caa45f300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't clearing optimizer buffers before adding new entries to it during deserialization. Successive calls to
torch::loadwith the same optimizer would just append to the buffer container. Also movedserialize()function fromtorch::optim::detailintotorch::optimso users can use it for custom optimizers.Fixes #15792
@ezyang