KEMBAR78
Fix inductor cuda sort nan behavior by eellison · Pull Request #159308 · pytorch/pytorch · GitHub
Skip to content

Fix inductor cuda sort nan behavior #159308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix inductor cuda sort nan behavior #159308

wants to merge 2 commits into from

Conversation

@eellison
Copy link
Contributor

@eellison eellison commented Jul 28, 2025 •
edited
Loading

@eellison
Update
8362ef2 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159308

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 3 Unrelated Failures

As of commit 8fa27ae with merge base 79aef14 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

eellison added a commit that referenced this pull request Jul 28, 2025
@eellison
Fix inductor cuda sort nan behavior
73ee4a5 
ghstack-source-id: d02ca8c
Pull Request resolved: #159308
@eellison eellison requested review from exclamaforte and isuruf July 28, 2025 23:18
isuruf
isuruf reviewed Jul 29, 2025
View reviewed changes
@eellison
Update
8fa27ae 
[ghstack-poisoned]
eellison added a commit that referenced this pull request Jul 29, 2025
@eellison
Fix inductor cuda sort nan behavior
0404ba3 
ghstack-source-id: 70d880d
Pull Request resolved: #159308
@eellison eellison requested a review from isuruf July 29, 2025 14:14
@eellison eellison added the topic: not user facing topic category label Jul 29, 2025
@eellison eellison requested a review from mlazos July 29, 2025 14:15
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 29, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / cuda12.8-py3.10-gcc9-sm80 / build

Details for Dev Infra team Raised by workflow job

@eellison
Copy link
Contributor Author

@pytorchbot merge -f "unrelated"

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 29, 2025

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@eellison
Copy link
Contributor Author

@pytorchbot merge -f "slow rocm test"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@eellison @yangw-dev
Fix inductor cuda sort nan behavior (#159308)
7e17d43 
Fix for #152423

Pull Request resolved: #159308
Approved by: https://github.com/isuruf
@github-actions github-actions bot deleted the gh/eellison/810/head branch August 29, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isuruf isuruf isuruf approved these changes

@exclamaforte exclamaforte Awaiting requested review from exclamaforte

@mlazos mlazos Awaiting requested review from mlazos

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eellison @pytorchmergebot @isuruf