KEMBAR78
Add pad and narrow to torch/csrc/stable/ops.h by mikaylagawarecki · Pull Request #159328 · pytorch/pytorch · GitHub
Skip to content

Add pad and narrow to torch/csrc/stable/ops.h #159328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Add pad and narrow to torch/csrc/stable/ops.h #159328

wants to merge 9 commits into from

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Jul 29, 2025 •
edited by pytorchmergebot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159328

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 4894a25 with merge base f33ce40 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Jul 29, 2025
@mikaylagawarecki
Add pad and narrow to torch/csrc/stable/ops.h
e581ae6 
ghstack-source-id: cdf805c
Pull Request resolved: #159328
mikaylagawarecki added a commit that referenced this pull request Jul 29, 2025
@mikaylagawarecki
Add pad and narrow to torch/csrc/stable/ops.h
43983cc 
ghstack-source-id: ef932ee
Pull Request resolved: #159328
@github-actions
Copy link
Contributor

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

This was referenced Jul 30, 2025
Closed
Closed
mikaylagawarecki added a commit that referenced this pull request Aug 4, 2025
@mikaylagawarecki
Add pad and narrow to torch/csrc/stable/ops.h
433b626 
ghstack-source-id: b6940ad
Pull Request resolved: #159328
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review August 4, 2025 21:18
mikaylagawarecki
mikaylagawarecki commented Aug 4, 2025
View reviewed changes
torch/csrc/stable/ops.h
// (2) SymInt is not yet header-only
inline Tensor pad(
const Tensor& self,
std::vector<int64_t> pad,
Copy link
Contributor Author

@mikaylagawarecki mikaylagawarecki Aug 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to wait for IntArrayRef before merging this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naw i'm happy with this. We can overload this anyway in the future.

janeyx99
janeyx99 reviewed Aug 6, 2025
View reviewed changes
mikaylagawarecki added a commit that referenced this pull request Aug 8, 2025
@mikaylagawarecki
Add pad and narrow to torch/csrc/stable/ops.h
fd4a629 
ghstack-source-id: e1a4b92
Pull Request resolved: #159328
janeyx99
janeyx99 reviewed Aug 11, 2025
View reviewed changes
mikaylagawarecki added a commit that referenced this pull request Aug 11, 2025
@mikaylagawarecki
Add pad and narrow to torch/csrc/stable/ops.h
43b95cd 
ghstack-source-id: 1155d44
Pull Request resolved: #159328
mikaylagawarecki added a commit that referenced this pull request Aug 11, 2025
@mikaylagawarecki
Add pad and narrow to torch/csrc/stable/ops.h
2fe0dab 
ghstack-source-id: b6b6c42
Pull Request resolved: #159328
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@mikaylagawarecki
Update
4894a25 
[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Aug 12, 2025
@mikaylagawarecki
Add pad and narrow to torch/csrc/stable/ops.h
1e1775e 
ghstack-source-id: 32511ee
Pull Request resolved: #159328
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/mikaylagawarecki/329/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/159328)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mikaylagawarecki
Copy link
Contributor Author

test_jit failure is flaky link, no idea why it can't be ignored by merge -i so gonna merge -f

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -f

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 12, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -f "test_jit failure is flaky link, no idea why it can't be ignored by merge -i"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

chuanhaozhuge pushed a commit that referenced this pull request Aug 14, 2025
@mikaylagawarecki @chuanhaozhuge
Add pad and narrow to torch/csrc/stable/ops.h (#159328)
0df5bcf 
Pull Request resolved: #159328
Approved by: https://github.com/janeyx99
ghstack dependencies: #159507
chuanhaozhuge pushed a commit that referenced this pull request Aug 18, 2025
@mikaylagawarecki @chuanhaozhuge
Add pad and narrow to torch/csrc/stable/ops.h (#159328)
f418180 
Pull Request resolved: #159328
Approved by: https://github.com/janeyx99
ghstack dependencies: #159507
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@mikaylagawarecki @can-gaa-hou
Add pad and narrow to torch/csrc/stable/ops.h (pytorch#159328)
5c5c373 
Pull Request resolved: pytorch#159328
Approved by: https://github.com/janeyx99
ghstack dependencies: pytorch#159507
@github-actions github-actions bot deleted the gh/mikaylagawarecki/329/head branch September 12, 2025 02:08
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@mikaylagawarecki @markc-614
Add pad and narrow to torch/csrc/stable/ops.h (pytorch#159328)
b642b13 
Pull Request resolved: pytorch#159328
Approved by: https://github.com/janeyx99
ghstack dependencies: pytorch#159507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: build release notes category release notes: inductor (aoti) topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikaylagawarecki @pytorchmergebot @janeyx99