Move complex to headeronly #159411
Closed
Move complex to headeronly #159411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159411
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7930e44 with merge base d2e0258 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
janeyx99
added
ciflow/trunk
desertfire
reviewed
Jul 30, 2025
| #include <torch/headeronly/util/complex.h> | ||
|
|
||
| // std functions | ||
| // |
There was a problem hiding this comment.
Why are the followings not moved?
There was a problem hiding this comment.
There is quite a lot in here, and complex_math.h is not header only, so I just moved the APIs I cared about.
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Jul 31, 2025
[ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
yangw-dev
pushed a commit
that referenced
this pull request
Aug 1, 2025
Pull Request resolved: #159411 Approved by: https://github.com/albanD ghstack dependencies: #159415
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 1, 2025
Pull Request resolved: #159416 Approved by: https://github.com/albanD ghstack dependencies: #159415, #159411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):