KEMBAR78
Fix aarch64 wheel pack by atalman · Pull Request #159481 · pytorch/pytorch · GitHub
Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Jul 30, 2025

PR that introduced the change: pytorch/builder#1775
Use wheel pack instead of zip to repack the wheel.
It should regenerate the RECORD file and update all the hashes correctly.

TODO:
Apply wheel pack instead of zip to Rest of builds
Add validation test to make sure wheel contents matches RECORD file

@atalman atalman requested a review from a team as a code owner July 30, 2025 15:40
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159481

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 114 Pending

As of commit bc2b43c with merge base eaadd12 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman changed the title Fix aarch64 wheel unpack Fix aarch64 wheel pack Jul 30, 2025
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention PR that introduced the failure. Also, is it possible to have a regression test for it?

@atalman atalman added the topic: not user facing topic category label Jul 30, 2025
@atalman atalman added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Jul 31, 2025
@atalman
Copy link
Contributor Author

atalman commented Sep 8, 2025

@pytorchmergebot merge -f "lint is good, the script is already passing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
PR that introduced the change: pytorch/builder#1775
Use wheel pack instead of zip to repack the wheel.
It should regenerate the RECORD file and update all the hashes correctly.

TODO:
Apply wheel pack instead of zip to Rest of builds
Add validation test to make sure wheel contents matches RECORD file

Pull Request resolved: pytorch#159481
Approved by: https://github.com/malfet
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
PR that introduced the change: pytorch/builder#1775
Use wheel pack instead of zip to repack the wheel.
It should regenerate the RECORD file and update all the hashes correctly.

TODO:
Apply wheel pack instead of zip to Rest of builds
Add validation test to make sure wheel contents matches RECORD file

Pull Request resolved: pytorch#159481
Approved by: https://github.com/malfet
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
PR that introduced the change: pytorch/builder#1775
Use wheel pack instead of zip to repack the wheel.
It should regenerate the RECORD file and update all the hashes correctly.

TODO:
Apply wheel pack instead of zip to Rest of builds
Add validation test to make sure wheel contents matches RECORD file

Pull Request resolved: pytorch#159481
Approved by: https://github.com/malfet
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
PR that introduced the change: pytorch/builder#1775
Use wheel pack instead of zip to repack the wheel.
It should regenerate the RECORD file and update all the hashes correctly.

TODO:
Apply wheel pack instead of zip to Rest of builds
Add validation test to make sure wheel contents matches RECORD file

Pull Request resolved: pytorch#159481
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants