KEMBAR78
Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI by janeyx99 · Pull Request #159604 · pytorch/pytorch · GitHub
Skip to content

Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI #159604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI #159604

wants to merge 5 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jul 31, 2025 •
edited
Loading

@janeyx99 janeyx99 mentioned this pull request Jul 31, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159604

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 810a751 with merge base 9b953bb (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Jul 31, 2025
@janeyx99
Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI
340ee1b 
ghstack-source-id: b9ba83a
Pull Request resolved: #159604
@janeyx99 janeyx99 requested a review from desertfire August 1, 2025 15:52
janeyx99 added a commit that referenced this pull request Aug 1, 2025
@janeyx99
Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI
eb30a41 
ghstack-source-id: ef6faa7
Pull Request resolved: #159604
@janeyx99 janeyx99 requested a review from albanD August 1, 2025 18:01
@janeyx99 janeyx99 added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 1, 2025
desertfire
desertfire reviewed Aug 1, 2025
View reviewed changes
torch/headeronly/util/shim_utils.h Outdated
#include <stdexcept>

#if defined(__GNUC__) || defined(__clang__)
#define TORCH_NOINLINE __attribute__((noinline))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simply use C10_NOINLINE now since it has been moved to a header-only file.

torch/headeronly/util/shim_utils.h Outdated
#define TORCH_SUCCESS 0
#define TORCH_FAILURE 1

TORCH_NOINLINE static void throw_exception(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using namespace detail and inline is more consistent with other header files, instead of using static.

janeyx99 added a commit that referenced this pull request Aug 1, 2025
@janeyx99
Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI
f91ae25 
ghstack-source-id: 6b2c43a
Pull Request resolved: #159604
albanD
albanD approved these changes Aug 4, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint needs fixing, but SGTM otherwise.

desertfire
desertfire approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@desertfire desertfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other that the part I commented.

torch/headeronly/util/shim_utils.h Outdated
#define TORCH_FAILURE 1

namespace torch::headeronly::detail {
C10_NOINLINE inline void throw_exception(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the churn, but looking at this conflicting declaration C10_NOINLINE inline, I realized my previous suggestion doesn't make sense. The reason of having C10_NOINLINE here is because it was causing very slow compilation. I think we still need the old way of declaring this as static.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, as in it was getting inlined everyone during compilation which made it slower?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace shouldn't affect anything, right?

janeyx99 added a commit that referenced this pull request Aug 5, 2025
@janeyx99
Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI
bae983e 
ghstack-source-id: b2a746a
Pull Request resolved: #159604
@janeyx99 janeyx99 added release notes: build release notes category and removed release notes: inductor (aoti) labels Aug 5, 2025
janeyx99 added a commit that referenced this pull request Aug 5, 2025
@janeyx99
Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI
be35bb0 
ghstack-source-id: 49b7404
Pull Request resolved: #159604
@janeyx99
Copy link
Contributor Author

janeyx99 commented Aug 5, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@janeyx99 janeyx99 mentioned this pull request Aug 25, 2025
Open
51 tasks
@github-actions github-actions bot deleted the gh/janeyx99/295/head branch September 5, 2025 02:10
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@janeyx99 @markc-614
Cut a version of TORCH_ERROR_CODE_CHECK in headeronly from AOTI (pyto…
1910a25 
…rch#159604)

Pull Request resolved: pytorch#159604
Approved by: https://github.com/albanD, https://github.com/desertfire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire desertfire approved these changes

@albanD albanD albanD approved these changes

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: build release notes category release notes: inductor (aoti)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janeyx99 @pytorchmergebot @desertfire @albanD