Fix AllocatorConfig potential SIO issue #159629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159629
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit aa82528 with merge base bb67660 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guangyey
added
topic: bug fixes
ScottTodd
approved these changes
Aug 1, 2025
|
@albanD May I know if you have any comments on this fix. |
|
@albanD Thanks for your support. I really appreciate it. |
|
Starting merge as part of PR stack under #156175 |
3 similar comments
|
Starting merge as part of PR stack under #156175 |
|
Starting merge as part of PR stack under #156175 |
|
Starting merge as part of PR stack under #156175 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 5, 2025
…0312) # Motivation Refactor `CUDAAllocatorConfig` to reuse `AcceleratorAllocatorConfig` and `ConfigTokenizer`. We would deprecate those option that overleap with `AcceleratorAllocatorConfig` in the following PR and keep them only for BC. Pull Request resolved: #150312 Approved by: https://github.com/albanD ghstack dependencies: #159629
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 5, 2025
…llocatorConfig instead (#156165) Pull Request resolved: #156165 Approved by: https://github.com/albanD ghstack dependencies: #159629, #150312
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 5, 2025
# Motivation This PR moves the implementation of `torch.cuda.memory._set_allocator_settings` to `torch._C._accelerator_setAllocatorSettings`. Since the original API was intended as a temporary/internal utility, I am not exposing the new function as a public API. Pull Request resolved: #156175 Approved by: https://github.com/albanD ghstack dependencies: #159629, #150312, #156165
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
# Motivation As @ScottTodd identified in this [comment](pytorch#150312 (comment)), using STL containers like `std::string` and `std::unordered_set` at static init time can cause static initialization order issues. This PR is based on and modified from his original PR: pytorch#159607. I’m stacking this PR here to help facilitate the landing and validation process. Co-authored-by: @ScottTodd Pull Request resolved: pytorch#159629 Approved by: https://github.com/ScottTodd, https://github.com/albanD
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…orch#150312) # Motivation Refactor `CUDAAllocatorConfig` to reuse `AcceleratorAllocatorConfig` and `ConfigTokenizer`. We would deprecate those option that overleap with `AcceleratorAllocatorConfig` in the following PR and keep them only for BC. Pull Request resolved: pytorch#150312 Approved by: https://github.com/albanD ghstack dependencies: pytorch#159629
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…llocatorConfig instead (pytorch#156165) Pull Request resolved: pytorch#156165 Approved by: https://github.com/albanD ghstack dependencies: pytorch#159629, pytorch#150312
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…6175) # Motivation This PR moves the implementation of `torch.cuda.memory._set_allocator_settings` to `torch._C._accelerator_setAllocatorSettings`. Since the original API was intended as a temporary/internal utility, I am not exposing the new function as a public API. Pull Request resolved: pytorch#156175 Approved by: https://github.com/albanD ghstack dependencies: pytorch#159629, pytorch#150312, pytorch#156165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
As @ScottTodd identified in this comment, using STL containers like
std::stringandstd::unordered_setat static init time can cause static initialization order issues. This PR is based on and modified from his original PR: #159607. I’m stacking this PR here to help facilitate the landing and validation process.Co-authored-by: @ScottTodd