KEMBAR78
[ONNX] Default to dynamo export by justinchuby · Pull Request #159646 · pytorch/pytorch · GitHub
Skip to content

[ONNX] Default to dynamo export #159646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[ONNX] Default to dynamo export #159646

wants to merge 7 commits into from

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Aug 1, 2025 •
edited
Loading

Set dynamo=True and enable fallback.

  1. Implemented the compatible behavior where BytesIO objects as f is accepted
  2. Update tests to explicitly set dynamo=False

#151693

cc @titaiwangms

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159646

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 5283603 with merge base b7e207c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 1, 2025
@justinchuby justinchuby added the keep-going Don't stop on first failure, keep running tests until the end label Aug 1, 2025
@justinchuby justinchuby reopened this Aug 14, 2025
@justinchuby justinchuby force-pushed the justinchuby/dynamo-true branch from 4c625cc to e57c158 Compare August 15, 2025 23:33
@justinchuby
BytesIO compat
5dc7264 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Remove some tests
b4bd700 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Update tests
a5e7b8b 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby requested a review from xadupre August 16, 2025 01:05
@justinchuby justinchuby added module: onnx Related to torch.onnx module: bc-breaking Related to a BC-breaking change and removed module: bc-breaking Related to a BC-breaking change labels Aug 16, 2025
@pytorch-bot pytorch-bot bot added the topic: bc breaking topic category label Aug 16, 2025
@justinchuby
Fix test
238e8a5 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby deleted the justinchuby/dynamo-true branch August 16, 2025 05:41
@facebook-github-bot
Copy link
Contributor

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 18, 2025
@pytorchmergebot
Revert "[ONNX] Default to dynamo export (#159646)"
82c7a1e 
This reverts commit 11b6ceb.

Reverted #159646 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#159646 (comment)))
@pytorchmergebot
Copy link
Collaborator

@justinchuby your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Aug 18, 2025
@titaiwangms
Copy link
Collaborator

cc @tugsbayasgalan @pianpwk @angelayi (Meta internal breaks)

@angelayi
Copy link
Contributor

angelayi commented Aug 18, 2025 •
edited
Loading

@titaiwangms I mentioned this in the slack channel but it seems like dynamo=True creates a dependency on onnxscript, which is not imported in our internal codebase, causing many failures. To fix this, we'll first patch all the internal code to call dynamo=False and then land this PR.

@justinchuby justinchuby restored the justinchuby/dynamo-true branch August 21, 2025 15:36
@justinchuby justinchuby reopened this Aug 21, 2025
@justinchuby
Copy link
Collaborator Author

Were you able to make the internal changes?

can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@justinchuby @can-gaa-hou
[ONNX] Default to dynamo export (pytorch#159646)
7920b8d 
Set dynamo=True and enable fallback.

1. Implemented the compatible behavior where BytesIO objects as `f` is accepted
2. Update tests to explicitly set dynamo=False

pytorch#151693

Pull Request resolved: pytorch#159646
Approved by: https://github.com/titaiwangms
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@pytorchmergebot @can-gaa-hou
Revert "[ONNX] Default to dynamo export (pytorch#159646)"
75825fb 
This reverts commit 11b6ceb.

Reverted pytorch#159646 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#159646 (comment)))
@justinchuby
Copy link
Collaborator Author

@angelayi checking again if you made any progress? Thanks!

@angelayi
Copy link
Contributor

Sorry I set up the codemod but it hasn't modified all the files yet! will update this thread once it's finished!

@justinchuby justinchuby modified the milestones: 2.10.0, 2.9.0 Aug 31, 2025
@titaiwangms titaiwangms linked an issue Sep 2, 2025 that may be closed by this pull request
[ONNX] Flip dynamo default to True in torch.onnx.export #151693
Closed
@justinchuby
Merge branch 'main' into justinchuby/dynamo-true
5283603 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@justinchuby @markc-614
[ONNX] Default to dynamo export (pytorch#159646)
7a1b651 
Set dynamo=True and enable fallback.

1. Implemented the compatible behavior where BytesIO objects as `f` is accepted
2. Update tests to explicitly set dynamo=False

pytorch#151693

Pull Request resolved: pytorch#159646
Approved by: https://github.com/titaiwangms
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@pytorchmergebot @markc-614
Revert "[ONNX] Default to dynamo export (pytorch#159646)"
6367874 
This reverts commit 11b6ceb.

Reverted pytorch#159646 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#159646 (comment)))
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@justinchuby @markc-614
[ONNX] Default to dynamo export (pytorch#159646)
69b0f9e 
Set dynamo=True and enable fallback.

1. Implemented the compatible behavior where BytesIO objects as `f` is accepted
2. Update tests to explicitly set dynamo=False

pytorch#151693

Pull Request resolved: pytorch#159646
Approved by: https://github.com/titaiwangms
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@justinchuby @mansiag05
[ONNX] Default to dynamo export (pytorch#159646)
c97bc05 
Set dynamo=True and enable fallback.

1. Implemented the compatible behavior where BytesIO objects as `f` is accepted
2. Update tests to explicitly set dynamo=False

pytorch#151693

Pull Request resolved: pytorch#159646
Approved by: https://github.com/titaiwangms
@github-actions github-actions bot deleted the justinchuby/dynamo-true branch October 3, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@xadupre xadupre Awaiting requested review from xadupre

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes Reverted topic: bc breaking topic category

Projects

None yet

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

[ONNX] Flip dynamo default to True in torch.onnx.export

6 participants

@justinchuby @pytorchmergebot @facebook-github-bot @titaiwangms @angelayi @pytorchbot