KEMBAR78
[BE][MPS] Build metal kernels of MacOS-14+ by malfet · Pull Request #159733 · pytorch/pytorch · GitHub
Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Aug 3, 2025

Stack from ghstack (oldest at bottom):

Which makes #if __METAL_VERSION__ >= 310 guards for bfloat use support unnecessary.
Rename kernels_bfloat.metallib into kernels_basic and remove custom build/selection logic.

Part of #159275

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159733

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 16 Pending, 1 Unrelated Failure

As of commit 40a0c8c with merge base 805a102 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Aug 3, 2025
@malfet malfet requested review from Skylion007 and dcci August 3, 2025 19:12
@malfet malfet added the topic: bc breaking topic category label Aug 3, 2025
malfet added 4 commits August 3, 2025 12:15
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@malfet
Copy link
Contributor Author

malfet commented Aug 3, 2025

@pytorchbot merge -f "MPS + lint are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/465/head branch September 3, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: bc breaking topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants