KEMBAR78
Pass fw/bw compilers to aot_export_joint_with_descriptors by wconstab · Pull Request #159814 · pytorch/pytorch · GitHub
Skip to content

Pass fw/bw compilers to aot_export_joint_with_descriptors #159814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Pass fw/bw compilers to aot_export_joint_with_descriptors #159814

wants to merge 2 commits into from

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Aug 4, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Allow overriding nop compilers with real ones when using this flow.

@wconstab
Pass fw/bw compilers to aot_export_joint_with_descriptors
952efcb 
Allow overriding nop compilers with real ones when using this flow.

[ghstack-poisoned]
@wconstab wconstab requested a review from bdhirsh as a code owner August 4, 2025 23:11
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159814

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (3 Unrelated Failures)

As of commit 42262ad with merge base 908c5cc (image):

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wconstab added a commit that referenced this pull request Aug 4, 2025
@wconstab
Pass fw/bw compilers to aot_export_joint_with_descriptors
ba8ea87 
Allow overriding nop compilers with real ones when using this flow.

ghstack-source-id: 364f10a
Pull Request resolved: #159814
@wconstab wconstab mentioned this pull request Aug 4, 2025
Merged
@wconstab
Update on "Pass fw/bw compilers to aot_export_joint_with_descriptors"
42262ad 
Allow overriding nop compilers with real ones when using this flow.

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Aug 5, 2025
@wconstab
Pass fw/bw compilers to aot_export_joint_with_descriptors
004cc92 
Allow overriding nop compilers with real ones when using this flow.

ghstack-source-id: b72b324
Pull Request resolved: #159814
@wconstab
Copy link
Contributor Author

wconstab commented Aug 5, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 5, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Check mergeability of ghstack PR / ghstack-mergeability-check

Details for Dev Infra team Raised by workflow job

@wconstab
Copy link
Contributor Author

wconstab commented Aug 5, 2025

@pytorch merge -i

@wconstab
Copy link
Contributor Author

wconstab commented Aug 6, 2025

@pytorchbot merge -f

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 6, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

@wconstab
Copy link
Contributor Author

wconstab commented Aug 6, 2025

@pytorchbot merge -f "broken mergability check?"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

wconstab added a commit to meta-pytorch/autoparallel that referenced this pull request Aug 8, 2025
@wconstab
Move compile into AutoParallel API (#77)
75cef61 
Requires upstream pytorch/pytorch#159814 to land first. (done)

also updates joint_with_descriptors meta info to reflect that arg/placeholder shapes have changed (inputs and params are now sharded, not global, as they were when first traced).

kicked off a verification run from this PR @ acaaf9c: https://www.internalfb.com/mlhub/pipelines/runs/mast/torchtitan-64-whc-kf1llhnr

tbm FSDP_eager:torchtitan-64-whc-p3s1bn compile_pr:torchtitan-64-whc-kf1llhnr compile_noac_from_update_post:torchtitan-64-fmassa-r4rvfnf6
@github-actions github-actions bot deleted the gh/wconstab/436/head branch September 6, 2025 02:07
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@wconstab @markc-614
Pass fw/bw compilers to aot_export_joint_with_descriptors (pytorch#15…
daf9089 
…9814)

Allow overriding nop compilers with real ones when using this flow.
Pull Request resolved: pytorch#159814
Approved by: https://github.com/fmassa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa fmassa approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: AO frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wconstab @pytorchmergebot @fmassa