[Profiler] Update README #159816
Closed
[Profiler] Update README #159816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159816
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d7f242a with merge base 289f62c ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D79604189 |
sraikund16
force-pushed
the
export-D79604189
branch
from
541a059 to
73a31bc
Compare
sraikund16
added a commit
to sraikund16/pytorch
that referenced
this pull request
Aug 5, 2025
Summary: Updated README with code structure and explanation of core features within profiler Test Plan: N/A Rollback Plan: Differential Revision: D79604189
|
This pull request was exported from Phabricator. Differential Revision: D79604189 |
sraikund16
added a commit
to sraikund16/pytorch
that referenced
this pull request
Aug 5, 2025
Summary: Updated README with code structure and explanation of core features within profiler Test Plan: N/A Rollback Plan: Differential Revision: D79604189
sraikund16
force-pushed
the
export-D79604189
branch
from
73a31bc to
c1f48d2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79604189 |
sraikund16
added a commit
to sraikund16/pytorch
that referenced
this pull request
Aug 5, 2025
Summary: Pull Request resolved: pytorch#159816 Updated README with code structure and explanation of core features within profiler Test Plan: N/A Rollback Plan: Differential Revision: D79604189
sraikund16
force-pushed
the
export-D79604189
branch
2 times, most recently
from
3ee28e0 to
03b2dda
Compare
sraikund16
added a commit
to sraikund16/pytorch
that referenced
this pull request
Aug 5, 2025
Summary: Updated README with code structure and explanation of core features within profiler Test Plan: N/A Rollback Plan: Differential Revision: D79604189
|
This pull request was exported from Phabricator. Differential Revision: D79604189 |
sanrise
approved these changes
Aug 6, 2025
| When a trace begins, the autograd/profiler backend calls into `profiler_kineto.cpp` to prepare, start, or stop collection. At the start of tracing, the `onFunctionEnter` and `onFunctionExit` callbacks defined in `profiler_kineto.cpp` are registered. | ||
|
|
||
| Callback registration can be either global or local, depending on the `ExperimentalConfig` used: | ||
| - **Global:** The callback is registered to all threads throughout execution. |
There was a problem hiding this comment.
Can you give an example of when the profiler would need to use global callback in ExperimentalConfig. The thread local callback makes sense to me.
There was a problem hiding this comment.
I was thinking of adding this to a tutorial instead so I can add some visuals to the difference?
aaronenyeshi
approved these changes
Aug 6, 2025
Summary: Updated README with code structure and explanation of core features within profiler Test Plan: N/A Rollback Plan: Reviewed By: aaronenyeshi Differential Revision: D79604189
sraikund16
force-pushed
the
export-D79604189
branch
from
03b2dda to
d7f242a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79604189 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Summary: Updated README with code structure and explanation of core features within profiler Test Plan: N/A Rollback Plan: Differential Revision: D79604189 Pull Request resolved: pytorch#159816 Approved by: https://github.com/sanrise, https://github.com/aaronenyeshi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updated README with code structure and explanation of core features within profiler
Test Plan:
N/A
Rollback Plan:
Differential Revision: D79604189