KEMBAR78
[BE] Update TensorPipe pin by malfet · Pull Request #159834 · pytorch/pytorch · GitHub
Skip to content

[BE] Update TensorPipe pin #159834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[BE] Update TensorPipe pin #159834

wants to merge 7 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

No functional changes, just:

  • Update C++ standard to C++17
  • Update cmake min version to 3.18
  • Update libuv dependency to 1.51 (to move its cmake min version to 3.10)
  • Replace boost optional implementation with std::optional wrapper
  • Make it compilable with gcc-14.x plus by including cstddef in few headers
  • Avoid using deprecated enums for MacOS builds

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta

@malfet
Update
29c7285 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159834

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (3 Unrelated Failures)

As of commit 33c02c1 with merge base 510e8b4 (image):

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (rpc) release notes category labels Aug 5, 2025
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
0b00ee8 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: dae0562
Pull Request resolved: #159834
@malfet malfet marked this pull request as draft August 5, 2025 02:36
@malfet
Update
9b367b8 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
1f1d75c 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: 122fccb
Pull Request resolved: #159834
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
9df0110 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: 122fccb
Pull Request resolved: #159834
@malfet malfet added release notes: build release notes category topic: improvements topic category labels Aug 5, 2025
@malfet
Update
55f7c85 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
fca65d4 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: cfb0d79
Pull Request resolved: #159834
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
a06a4ee 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: cfb0d79
Pull Request resolved: #159834
@malfet malfet marked this pull request as ready for review August 5, 2025 16:15
@malfet malfet mentioned this pull request Aug 5, 2025
Closed
@malfet
Update
5957029 
[ghstack-poisoned]
@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 5, 2025
@malfet
Update
02f2f0f 
[ghstack-poisoned]
@malfet malfet added the no-runner-experiments Bypass Meta/LF runner determinator label Aug 5, 2025
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
a7b3cb3 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: 7aba5d6
Pull Request resolved: #159834
@malfet
Update
a88ac46 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
7f06f8e 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: 9be1011
Pull Request resolved: #159834
@malfet
Update
33c02c1 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
56bf990 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: 581ab5f
Pull Request resolved: #159834
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[BE] Update TensorPipe version
80b0fae 
To include minor modern-compiler compatibility fixes

And dependency updates

ghstack-source-id: 581ab5f
Pull Request resolved: #159834
@malfet malfet changed the title [BE] Update TensorPipe version [BE] Update TensorPipe pin Aug 5, 2025
@malfet
Copy link
Contributor Author

malfet commented Aug 5, 2025

@pytorchbot merge -f "Lint + builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/466/head branch September 5, 2025 02:09
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[BE] Update TensorPipe pin (pytorch#159834)
eae780c 
No functional changes, just:
- Update C++ standard to C++17
- Update `cmake` min version to 3.18
- Update `libuv` dependency to 1.51 (to move its cmake min version to 3.10)
- Replace boost optional implementation with `std::optional` wrapper
- Make it compilable with gcc-14.x plus by including `cstddef` in few headers
-  Avoid using deprecated enums for MacOS builds

Pull Request resolved: pytorch#159834
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@jiayisuse jiayisuse Awaiting requested review from jiayisuse

@osalpekar osalpekar Awaiting requested review from osalpekar

@lw lw Awaiting requested review from lw

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged no-runner-experiments Bypass Meta/LF runner determinator oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: build release notes category release notes: distributed (rpc) release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @Skylion007