[AOTInductor] ABI-Compatibility for RecordFunction. #159842

muchulee8 · 2025-08-05T06:21:36Z

Stack from ghstack (oldest at bottom):

Summary:
Previous our implementation for RecordFunction injects Aten into
codegen, which is breaking the ABI contract for AOTInductor.

C10::IValue is aded to call the full record function. The extension of
more profiling info will come in later PRs.

Test Plan:
Included in commit.

Reviewers:

Subscribers:

Tasks:

Tags:

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @amjames @chauhang @aakhundov @coconutruben

Differential Revision: D79622071

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

pytorch-bot · 2025-08-05T06:21:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159842

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 9181f12 with merge base a2fd106 ():

NEW FAILURE - The following job has failed:

windows-arm64-build-test / test (gh)
ModuleNotFoundError: No module named 'torch'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b25922b Pull Request resolved: #159842

muchulee8 · 2025-08-05T06:24:21Z

@muchulee8 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

github-actions · 2025-08-05T06:25:37Z

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

iremyux · 2025-08-05T17:58:59Z

Adding ciflow/win-arm64 label to trigger Windows Arm64 CI.
(This is for testing purposes only and isn’t related to any changes in this PR.)

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng amjames chauhang aakhundov coconutruben Differential Revision: [D79622071](https://our.internmc.facebook.com/intern/diff/D79622071) [ghstack-poisoned]

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d454534 Pull Request resolved: #159842

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng amjames chauhang aakhundov coconutruben Differential Revision: [D79622071](https://our.internmc.facebook.com/intern/diff/D79622071) [ghstack-poisoned]

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b9cd2fd Pull Request resolved: #159842

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng amjames chauhang aakhundov coconutruben Differential Revision: [D79622071](https://our.internmc.facebook.com/intern/diff/D79622071) [ghstack-poisoned]

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3f7fc47 Pull Request resolved: #159842

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng amjames chauhang aakhundov coconutruben Differential Revision: [D79622071](https://our.internmc.facebook.com/intern/diff/D79622071) [ghstack-poisoned]

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 94cc011 Pull Request resolved: #159842

muchulee8 · 2025-08-06T04:55:30Z

@muchulee8 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

torch/_inductor/codegen/cpp.py

torch/csrc/inductor/aoti_torch/shim_common.cpp

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng amjames chauhang aakhundov coconutruben Differential Revision: [D79622071](https://our.internmc.facebook.com/intern/diff/D79622071) [ghstack-poisoned]

muchulee8 · 2025-08-13T21:10:54Z

@pytorchbot rebase

pytorchmergebot · 2025-08-13T21:12:27Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 0123499 Pull Request resolved: #159842

pytorchmergebot · 2025-08-13T21:12:40Z

Successfully rebased gh/muchulee8/63/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/159842)

muchulee8 · 2025-08-14T22:43:34Z

@pytorchbot merge

pytorchmergebot · 2025-08-14T22:45:20Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team

Raised by workflow job

muchulee8 · 2025-08-15T02:54:11Z

@muchulee8 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-08-15T21:18:17Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2025-08-15T21:20:53Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-08-15T21:21:10Z

Merge failed

Reason: 1 jobs have failed, first few of them are: windows-arm64-build-test / test

Details for Dev Infra team

Raised by workflow job

clee2000 · 2025-08-15T21:43:50Z

@pytorchbot merge -f "merged internally, win arm64 failure unrelated"

pytorchmergebot · 2025-08-15T21:45:27Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Summary: Previous our implementation for RecordFunction injects Aten into codegen, which is breaking the ABI contract for AOTInductor. C10::IValue is aded to call the full record function. The extension of more profiling info will come in later PRs. Test Plan: Included in commit. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D79622071](https://our.internmc.facebook.com/intern/diff/D79622071) Pull Request resolved: pytorch#159842 Approved by: https://github.com/desertfire

pytorch-bot bot added ciflow/inductor module: inductor release notes: inductor (aoti) labels Aug 5, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 5, 2025

iremyux added the ciflow/win-arm64 Trigger Windows Arm64 CI Workflows label Aug 5, 2025

muchulee8 requested review from chenyang78 and desertfire August 6, 2025 18:15

desertfire reviewed Aug 6, 2025

View reviewed changes

torch/_inductor/codegen/cpp.py Show resolved Hide resolved

torch/csrc/inductor/aoti_torch/shim_common.cpp Show resolved Hide resolved

muchulee8 mentioned this pull request Aug 7, 2025

[AOTInductor] Add grid information for Triton Kernels #160131

Closed

desertfire approved these changes Aug 8, 2025

View reviewed changes

torch/csrc/inductor/aoti_torch/shim_common.cpp Show resolved Hide resolved

muchulee8 mentioned this pull request Aug 11, 2025

[AOTInductor] Add input information for Triton Kernels in AOTI #160380

Closed

Update

9181f12

[ghstack-poisoned]

pytorchmergebot added the merging label Aug 14, 2025

pytorchmergebot removed the merging label Aug 14, 2025

pytorchmergebot added the merging label Aug 15, 2025

pytorchmergebot removed the merging label Aug 15, 2025

pytorchmergebot added the merging label Aug 15, 2025

pytorchmergebot closed this in 40311e2 Aug 15, 2025

pytorchmergebot added Merged and removed merging labels Aug 15, 2025

github-actions bot deleted the gh/muchulee8/63/head branch September 15, 2025 02:15

[AOTInductor] ABI-Compatibility for RecordFunction. #159842

[AOTInductor] ABI-Compatibility for RecordFunction. #159842

Uh oh!

Conversation

muchulee8 commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159842

❌ 1 New Failure

Uh oh!

muchulee8 commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 5, 2025

Attention! PyTorch one of the C-stable API file was changed

Uh oh!

iremyux commented Aug 5, 2025

Uh oh!

muchulee8 commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muchulee8 commented Aug 13, 2025

Uh oh!

pytorchmergebot commented Aug 13, 2025

Uh oh!

pytorchmergebot commented Aug 13, 2025

Uh oh!

muchulee8 commented Aug 14, 2025

Uh oh!

pytorchmergebot commented Aug 14, 2025

Merge failed

Uh oh!

muchulee8 commented Aug 15, 2025

Uh oh!

facebook-github-bot commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Merge started

Uh oh!

pytorchmergebot commented Aug 15, 2025

Merge failed

Uh oh!

clee2000 commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

muchulee8 commented Aug 5, 2025 •

edited

Loading

pytorch-bot bot commented Aug 5, 2025 •

edited

Loading