KEMBAR78
windows python 3.14 nightly builds by atalman · Pull Request #159869 · pytorch/pytorch · GitHub
Skip to content

windows python 3.14 nightly builds #159869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

windows python 3.14 nightly builds #159869

wants to merge 1 commit into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Aug 5, 2025 •
edited by pytorch-bot bot
Loading

@atalman atalman requested a review from a team as a code owner August 5, 2025 14:55
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159869

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 5 Pending, 3 Unrelated Failures

As of commit 6deb137 with merge base 284b719 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 5, 2025
@albanD
Copy link
Collaborator

albanD commented Aug 5, 2025

Skipping PR sanity check as this is generated files

@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Aug 5, 2025
albanD
albanD reviewed Aug 6, 2025
View reviewed changes
.ci/pytorch/windows/setup_build.bat Outdated
%PYTHON_EXEC% --version
set "PATH=%CD%\Python\Lib\site-packages\cmake\data\bin;%CD%\Python\Scripts;%CD%\Python;%PATH%"
if "%DESIRED_PYTHON%" == "3.14t" %PYTHON_EXEC% -m pip install numpy==2.2.1 cmake
if "%DESIRED_PYTHON%" == "3.14" %PYTHON_EXEC% -m pip install numpy==2.2.2 cmake
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have appropriate requirements* file to set these?

Copy link
Contributor Author

@atalman atalman Aug 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point we should probably move this to requirements, this is artifacts builder scripts I believe :) I think this can be done as followup BE change

malfet
malfet approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a horrible copy-pasta, but sure...

atalman
atalman commented Aug 14, 2025
View reviewed changes
@atalman atalman mentioned this pull request Aug 14, 2025
Open
@malfet
Copy link
Contributor

malfet commented Aug 18, 2025

Do you mind separating linux-aarch64 PR from Windows? Or do you want me to create one for linux-aarch64?

@atalman atalman marked this pull request as draft August 19, 2025 01:25
@atalman
Copy link
Contributor Author

atalman commented Aug 19, 2025

@malfet aarch64 already landed, this is still wip

@atalman atalman changed the title Add linux-aarch64 and windows python 3.14 nightly builds windows python 3.14 nightly builds Aug 19, 2025
@atalman
Add windows python 3.14 nightly builds
6deb137 
Python 3.14 add Windows and Linux aarch64

fix

fix

fix

fix

Remove including files with error

Revert "Remove including files with error"

This reverts commit 7a37118.

one_more_try

fix

git Revert "fix"

This reverts commit fbb7d7f.

Revert "one_more_try"

This reverts commit a667ccb.

Reapply "Remove including files with error"

This reverts commit a8fd532.

Revert "Remove including files with error"

This reverts commit 7a37118.

test

more_windows

bring_back

test

fix
@atalman atalman force-pushed the windows_314_python branch from 3518ddb to 6deb137 Compare August 19, 2025 12:33
@atalman atalman marked this pull request as ready for review August 19, 2025 16:43
williamwen42
williamwen42 approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@williamwen42 williamwen42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dynamo side lgtm

@atalman
Copy link
Contributor Author

atalman commented Aug 19, 2025

@pytorchmergebot merge -f "signal is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@chuanqi129 chuanqi129 mentioned this pull request Aug 22, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Aug 22, 2025
@chuanqi129 @pytorchmergebot
[CD] Enable triton xpu Windows build for Python 3.14 (#161255)
a43480d 
Follow #159869
Pull Request resolved: #161255
Approved by: https://github.com/atalman
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@atalman @markc-614
windows python 3.14 nightly builds (pytorch#159869)
9aa3b8a 
Related to pytorch#156856

Pull Request resolved: pytorch#159869
Approved by: https://github.com/malfet, https://github.com/williamwen42
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@chuanqi129 @markc-614
[CD] Enable triton xpu Windows build for Python 3.14 (pytorch#161255)
272053f 
Follow pytorch#159869
Pull Request resolved: pytorch#161255
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD left review comments

@malfet malfet malfet approved these changes

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor Merged module: dynamo skip-pr-sanity-checks topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atalman @albanD @malfet @pytorchmergebot @williamwen42