Fix meta for constant_pad_nd #159878
Fix meta for constant_pad_nd #159878
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159878
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit edc4b3c with merge base ee1b041 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| f"{l_inp} dimensions.", | ||
| ) | ||
|
|
||
| if all(isinstance(p, utils.IntWithoutSymInt) and p <= 0 for p in pad): |
There was a problem hiding this comment.
Why doesn't this logic work with symint?
There was a problem hiding this comment.
Because we can't do a branching based on the symint value in the meta function AFAIK.
There was a problem hiding this comment.
Would be better for dynamic shapes to be working... cc @laithsakka @bobrenjc93
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: Check mergeability of ghstack PR / ghstack-mergeability-check Details for Dev Infra teamRaised by workflow job |
[ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#144187 Pull Request resolved: pytorch#159878 Approved by: https://github.com/Skylion007, https://github.com/ezyang
Fixes pytorch#144187 Pull Request resolved: pytorch#159878 Approved by: https://github.com/Skylion007, https://github.com/ezyang
5 participants
Stack from ghstack (oldest at bottom):
Fixes #144187
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @mlazos