KEMBAR78
[Easy] Fix wrong propagation of fallback_ops_dict in gen_aoti_c_shim by mikaylagawarecki · Pull Request #159904 · pytorch/pytorch · GitHub
Skip to content

[Easy] Fix wrong propagation of fallback_ops_dict in gen_aoti_c_shim #159904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Easy] Fix wrong propagation of fallback_ops_dict in gen_aoti_c_shim #159904

wants to merge 1 commit into from

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Aug 5, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159904

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job, 3 Unrelated Failures

As of commit 2872ef2 with merge base aeb5321 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Aug 5, 2025
@mikaylagawarecki
[Easy] Fix wrong propagation of fallback_ops_dict in gen_aoti_c_shim
1e34eda 
ghstack-source-id: 37f0454
Pull Request resolved: #159904
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review August 5, 2025 21:57
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 5, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: Check Labels / Check labels, Check mergeability of ghstack PR / ghstack-mergeability-check

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2)

Details for Dev Infra team Raised by workflow job

@iremyux
Copy link
Collaborator

iremyux commented Aug 6, 2025

Adding ciflow/win-arm64 label to trigger Windows Arm64 CI and its test purposes - nothing about this PR specifically. (It should not effect the acceptance of the PR even if it fails.)

@iremyux iremyux added the ciflow/win-arm64 Trigger Windows Arm64 CI Workflows label Aug 6, 2025
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 4 checks: Check Labels / Check labels, Check mergeability of ghstack PR / ghstack-mergeability-check, pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable), trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/mikaylagawarecki/333/head branch September 6, 2025 02:06
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@mikaylagawarecki @markc-614
[Easy] Fix wrong propagation of fallback_ops_dict in gen_aoti_c_shim (p…
3ea3317 
…ytorch#159904)

Pull Request resolved: pytorch#159904
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/win-arm64 Trigger Windows Arm64 CI Workflows Merged release notes: inductor (aoti) topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikaylagawarecki @pytorchmergebot @iremyux @janeyx99