[CI][CD] Fix install_nvshem function
#159907
Conversation
When one builds CD docker, all CUDA dependencies must be installed into `/usr/local/cuda/` folder
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159907
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 4076d96 with merge base 64cc6f0 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge -f "Lint + binary builds are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Thanks for the fix! Indeed I wouldn't know CD has a different Docker build way than CI. Just a minor thing -- I am actually a bit surprised that CMake can still find the header file after this move. Lines 1014 to 1017 in 8e6a313 Both NVSHMEM_HOME and NVSHMEM_PY_DIR are empty in your test above.Yet CMake is still able to find the header under /usr/local/cuda. That seems to indicate that /usr/local/cuda is now one of the default search path of find_path?
|
When one builds CD docker, all CUDA dependencies must be installed into `/usr/local/cuda/` folder Test plan: Looks at the binary build logs, for example [here](https://github.com/pytorch/pytorch/actions/runs/16768141521/job/47477380147?pr=159907): ``` 2025-08-06T05:58:00.7347471Z -- NVSHMEM_HOME set to: '' 2025-08-06T05:58:00.7348378Z -- NVSHMEM wheel installed at: '' 2025-08-06T05:58:00.7392528Z -- NVSHMEM_HOST_LIB: '/usr/local/cuda/lib64/libnvshmem_host.so' 2025-08-06T05:58:00.7393251Z -- NVSHMEM_DEVICE_LIB: '/usr/local/cuda/lib64/libnvshmem_device.a' 2025-08-06T05:58:00.7393792Z -- NVSHMEM_INCLUDE_DIR: '/usr/local/cuda/include' 2025-08-06T05:58:00.7394252Z -- NVSHMEM found, building with NVSHMEM support ``` Pull Request resolved: pytorch#159907 Approved by: https://github.com/Skylion007, https://github.com/ngimel
5 participants
When one builds CD docker, all CUDA dependencies must be installed into
/usr/local/cuda/folderTest plan: Looks at the binary build logs, for example here: