KEMBAR78
[MPS] Remove all pre-MacOS14 logic by malfet · Pull Request #159912 · pytorch/pytorch · GitHub
Skip to content

[MPS] Remove all pre-MacOS14 logic #159912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[MPS] Remove all pre-MacOS14 logic #159912

wants to merge 3 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Aug 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Delete older enums, checks for MacOS-13.3+ for int64 support, etc

Fixes #159275

@malfet
Update
61881df 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner August 5, 2025 23:11
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159912

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 7c8be5b with merge base 8034b2a (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Aug 5, 2025
malfet added a commit that referenced this pull request Aug 5, 2025
@malfet
[MPS] Remove all pre-MacOS14 logic
616d2c5 
Delete older enums, checks for MacOS-13.3+ for int64 support, etc

Fixes #159275

ghstack-source-id: 1339878
Pull Request resolved: #159912
@malfet malfet requested review from Skylion007 and dcci August 5, 2025 23:11
@malfet malfet added the topic: bc breaking topic category label Aug 5, 2025
@malfet
Update
5d9fc7e 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Aug 6, 2025
@malfet
[MPS] Remove all pre-MacOS14 logic
b1b1121 
Delete older enums, checks for MacOS-13.3+ for int64 support, etc

Fixes #159275

ghstack-source-id: cdbc3c3
Pull Request resolved: #159912
@malfet
Update
7c8be5b 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Aug 6, 2025
@malfet
[MPS] Remove all pre-MacOS14 logic
90becef 
Delete older enums, checks for MacOS-13.3+ for int64 support, etc

Fixes #159275

ghstack-source-id: bdfb049
Pull Request resolved: #159912
manuelcandales
manuelcandales reviewed Aug 6, 2025
View reviewed changes
aten/src/ATen/native/mps/operations/ScanKernel.mm
#include <ATen/native/mps/ScanKernel_metallib.h>
#endif

// Generic scan implementation that handles both simple scans and scans with indices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also delete the respective metal shaders. But this can be on a follow up PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've already did that, haven't I?

@malfet
Copy link
Contributor Author

malfet commented Aug 6, 2025

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/471/head branch September 6, 2025 02:07
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[MPS] Remove all pre-MacOS14 logic (pytorch#159912)
24feec1 
Delete older enums, checks for MacOS-13.3+ for int64 support, etc

Fixes pytorch#159275
Pull Request resolved: pytorch#159912
Approved by: https://github.com/manuelcandales
malfet added a commit that referenced this pull request Oct 8, 2025
@malfet
[MPS] Update OS version in error message
2c0e1be 
Followup after #159912
Fixes #164943
@malfet malfet mentioned this pull request Oct 8, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 8, 2025
@malfet @pytorchmergebot
[MPS] Update OS version in error message (#164946)
01f3a43 
Followup after #159912
Fixes #164943

Pull Request resolved: #164946
Approved by: https://github.com/Camyll
pytorchbot pushed a commit that referenced this pull request Oct 8, 2025
@malfet @pytorchbot
[MPS] Update OS version in error message (#164946)
00caeaf 
Followup after #159912
Fixes #164943

Pull Request resolved: #164946
Approved by: https://github.com/Camyll

(cherry picked from commit 01f3a43)
@pytorchbot pytorchbot mentioned this pull request Oct 8, 2025
Merged
malfet added a commit that referenced this pull request Oct 8, 2025
@pytorchbot @malfet
[MPS] Update OS version in error message (#164949)
26e023a 
[MPS] Update OS version in error message (#164946)

Followup after #159912
Fixes #164943

Pull Request resolved: #164946
Approved by: https://github.com/Camyll

(cherry picked from commit 01f3a43)

Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@malfet @Chao1Han
[MPS] Update OS version in error message (pytorch#164946)
2f3bcca 
Followup after pytorch#159912
Fixes pytorch#164943

Pull Request resolved: pytorch#164946
Approved by: https://github.com/Camyll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@dcci dcci Awaiting requested review from dcci

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @manuelcandales