KEMBAR78
Improve pin_memory error message on CPU-only systems by ezyang · Pull Request #159994 · pytorch/pytorch · GitHub
Skip to content

Improve pin_memory error message on CPU-only systems #159994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve pin_memory error message on CPU-only systems #159994

wants to merge 1 commit into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 6, 2025

Summary

  • clarify pin_memory error message when no accelerator backend is available

Testing

  • python repro_pin_memory.py (fails: Need to provide pin_memory allocator to use pin memory)
  • lintrunner -a

https://chatgpt.com/codex/tasks/task_e_6893ba92c93483238a9bdfdd6c52812b

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159994

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit a3ed213 with merge base 512b473 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

albanD
albanD approved these changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@ezyang ezyang changed the base branch from codex-testing to main August 6, 2025 21:02
@ezyang ezyang force-pushed the codex/fix-pin_memory-error-handling branch from 06935b9 to a3ed213 Compare August 6, 2025 21:03
@ezyang
Copy link
Contributor Author

ezyang commented Aug 6, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 6, 2025
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@vadimkantorov
Copy link
Contributor

Or might it be useful to turn it into a single-time warning instead? (and just allocate with a normal allocator and proceed with regular RAM allocator)

@ezyang ezyang added release notes: python_frontend python frontend release notes category topic: bug fixes topic category labels Aug 6, 2025
@ezyang
Copy link
Contributor Author

ezyang commented Aug 6, 2025

@vadimkantorov I don't have too much of an opinion but that change is much more irreversible :)

@ezyang
Copy link
Contributor Author

ezyang commented Aug 8, 2025

@pytorchbot merge -f "unrelated problems"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

hinriksnaer pushed a commit to hinriksnaer/pytorch that referenced this pull request Aug 8, 2025
@ezyang @hinriksnaer
Improve pin_memory error message on CPU-only systems (pytorch#159994)
2daff6b 
## Summary
- clarify pin_memory error message when no accelerator backend is available

## Testing
- `python repro_pin_memory.py` (fails: Need to provide pin_memory allocator to use pin memory)
- `lintrunner -a`

------
https://chatgpt.com/codex/tasks/task_e_6893ba92c93483238a9bdfdd6c52812b
Pull Request resolved: pytorch#159994
Approved by: https://github.com/albanD
@github-actions github-actions bot deleted the codex/fix-pin_memory-error-handling branch September 8, 2025 02:14
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@ezyang @markc-614
Improve pin_memory error message on CPU-only systems (pytorch#159994)
303fefd 
## Summary
- clarify pin_memory error message when no accelerator backend is available

## Testing
- `python repro_pin_memory.py` (fails: Need to provide pin_memory allocator to use pin memory)
- `lintrunner -a`

------
https://chatgpt.com/codex/tasks/task_e_6893ba92c93483238a9bdfdd6c52812b
Pull Request resolved: pytorch#159994
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request codex Merged release notes: python_frontend python frontend release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @vadimkantorov @albanD