Warn when there is side effect in strict mode #160060

tugsbayasgalan · 2025-08-07T05:31:16Z

Stack from ghstack (oldest at bottom):

-> Warn when there is side effect in strict mode #160060

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

Differential Revision: D79784354

[ghstack-poisoned]

pytorch-bot · 2025-08-07T05:31:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160060

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 72327d4 with merge base f33ce40 ():

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable) (gh) (#158876)
/var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: aa3244c Pull Request resolved: #160060

tugsbayasgalan · 2025-08-07T05:33:07Z

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354) [ghstack-poisoned]

ghstack-source-id: f232de8 Pull Request resolved: #160060

tugsbayasgalan · 2025-08-07T16:09:20Z

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354) [ghstack-poisoned]

@voznesenskym

Pull Request resolved: #160060 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @imported-using-ghimport Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354/) ghstack-source-id: 302456107

facebook-github-bot · 2025-08-12T17:31:23Z

This pull request was exported from Phabricator. Differential Revision: D79784354

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354) [ghstack-poisoned]

@voznesenskym

Pull Request resolved: #160060 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @imported-using-ghimport Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354/) ghstack-source-id: 302460184

facebook-github-bot · 2025-08-12T17:38:54Z

This pull request was exported from Phabricator. Differential Revision: D79784354

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354) [ghstack-poisoned]

@voznesenskym

Pull Request resolved: #160060 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @imported-using-ghimport Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354/) ghstack-source-id: 302472385

facebook-github-bot · 2025-08-12T18:16:18Z

This pull request was exported from Phabricator. Differential Revision: D79784354

tugsbayasgalan · 2025-08-12T21:04:42Z

@pytorchbot rebase

pytorchmergebot · 2025-08-12T21:06:10Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]

pytorchmergebot · 2025-08-12T21:06:24Z

Successfully rebased gh/tugsbayasgalan/1/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/160060)

@voznesenskym

Pull Request resolved: #160060 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @imported-using-ghimport Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354/) ghstack-source-id: 70717d9

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354) [ghstack-poisoned]

@voznesenskym

Pull Request resolved: #160060 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @imported-using-ghimport Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354/) ghstack-source-id: 302716194

StrongerXi

Nice!

StrongerXi · 2025-08-13T16:39:12Z

test/export/test_export.py

+            UserWarning,
+            "While exporting, we found certain side effects happened in the model.forward. "
+            "Here are the list of potential sources you can double check: "
+            "\[\"L\['global_list'\]\", \"L\['self'\].bank\", \"L\['self'\].bank_dict\"",


On actual UX, we'd need more user education on how to interpret this (or we spit out the information with a friendlier format). For reference, it took me some time to fully understand this notation when I was ramping up

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354) [ghstack-poisoned]

@voznesenskym

Pull Request resolved: #160060 cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela @imported-using-ghimport Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354/) ghstack-source-id: cede38a

tugsbayasgalan · 2025-08-14T02:46:45Z

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-08-14T14:57:28Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2025-08-14T14:59:21Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Differential Revision: [D79784354](https://our.internmc.facebook.com/intern/diff/D79784354) Pull Request resolved: pytorch#160060 Approved by: https://github.com/zhxchen17, https://github.com/StrongerXi

Error when there is side effect in strict mode

69384c3

[ghstack-poisoned]

tugsbayasgalan requested review from angelayi, avikchaudhuri, ydwu4 and zhxchen17 as code owners August 7, 2025 05:31

pytorch-bot bot added ciflow/inductor module: dynamo release notes: export labels Aug 7, 2025

tugsbayasgalan added a commit that referenced this pull request Aug 7, 2025

Error when there is side effect in strict mode

3788624

ghstack-source-id: aa3244c Pull Request resolved: #160060

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 7, 2025

tugsbayasgalan added a commit that referenced this pull request Aug 7, 2025

Error when there is side effect in strict mode

1f842bd

ghstack-source-id: f232de8 Pull Request resolved: #160060

facebook-github-bot added the fb-exported label Aug 12, 2025

tugsbayasgalan changed the title ~~Error when there is side effect in strict mode~~ Warn when there is side effect in strict mode Aug 12, 2025

zhxchen17 approved these changes Aug 12, 2025

View reviewed changes

Update

b175aa8

[ghstack-poisoned]

StrongerXi approved these changes Aug 13, 2025

View reviewed changes

pytorchmergebot added the merging label Aug 14, 2025

pytorchmergebot closed this in 4a773e1 Aug 14, 2025

pytorchmergebot added Merged and removed merging labels Aug 14, 2025

github-actions bot deleted the gh/tugsbayasgalan/1/head branch September 14, 2025 02:14

Warn when there is side effect in strict mode #160060

Warn when there is side effect in strict mode #160060

Uh oh!

Conversation

tugsbayasgalan commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160060

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

tugsbayasgalan commented Aug 7, 2025

Uh oh!

tugsbayasgalan commented Aug 7, 2025

Uh oh!

facebook-github-bot commented Aug 12, 2025

Uh oh!

facebook-github-bot commented Aug 12, 2025

Uh oh!

facebook-github-bot commented Aug 12, 2025

Uh oh!

tugsbayasgalan commented Aug 12, 2025

Uh oh!

pytorchmergebot commented Aug 12, 2025

Uh oh!

pytorchmergebot commented Aug 12, 2025

Uh oh!

StrongerXi left a comment

Choose a reason for hiding this comment

Uh oh!

StrongerXi Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

tugsbayasgalan commented Aug 14, 2025

Uh oh!

facebook-github-bot commented Aug 14, 2025

Uh oh!

pytorchmergebot commented Aug 14, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tugsbayasgalan commented Aug 7, 2025 •

edited

Loading

pytorch-bot bot commented Aug 7, 2025 •

edited

Loading