KEMBAR78
[MPS] Extend `index_put` to complex types by malfet · Pull Request #160159 · pytorch/pytorch · GitHub
Skip to content

[MPS] Extend index_put to complex types #160159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Extend index_put to complex types #160159

wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 8, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

And delete confusing supported types check.
Move all pseudo atomic (but eventually consistent) ops to c10/metal/atomic.h header

Fixes #160034

@malfet
Update
2f3a5ff 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner August 8, 2025 02:21
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160159

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit 2aa48ec with merge base 2507ae6 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Aug 8, 2025
@malfet malfet requested a review from dcci August 8, 2025 02:21
@malfet malfet added the topic: improvements topic category label Aug 8, 2025
@malfet malfet requested a review from Skylion007 August 8, 2025 02:22
@malfet
Update
2aa48ec 
[ghstack-poisoned]
@malfet malfet requested a review from manuelcandales August 8, 2025 13:36
@malfet
Copy link
Contributor Author

malfet commented Aug 8, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 8, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: linux-aarch64 / linux-jammy-aarch64-py3.10 / test (default, 3, 3, linux.arm64.m8g.4xlarge), trunk / before-test / target-determination

Details for Dev Infra team Raised by workflow job

Skylion007
Skylion007 reviewed Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit shouldn't long diff be a ptrdiff type? That way it can preserve ptr aliasing semantic

@malfet
Copy link
Contributor Author

malfet commented Aug 8, 2025

@pytorchbot merge -f "Lint + MacOS signal are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

hinriksnaer pushed a commit to hinriksnaer/pytorch that referenced this pull request Aug 8, 2025
@malfet @hinriksnaer
[MPS] Extend index_put to complex types (pytorch#160159)
8450344 
And delete confusing supported types check.
Move all pseudo atomic (but eventually consistent) ops to `c10/metal/atomic.h` header

Fixes pytorch#160034
Pull Request resolved: pytorch#160159
Approved by: https://github.com/manuelcandales, https://github.com/dcci, https://github.com/Skylion007
@github-actions github-actions bot deleted the gh/malfet/476/head branch September 8, 2025 02:14
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[MPS] Extend index_put to complex types (pytorch#160159)
c4e937a 
And delete confusing supported types check.
Move all pseudo atomic (but eventually consistent) ops to `c10/metal/atomic.h` header

Fixes pytorch#160034
Pull Request resolved: pytorch#160159
Approved by: https://github.com/manuelcandales, https://github.com/dcci, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@dcci dcci dcci approved these changes

@manuelcandales manuelcandales manuelcandales approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @Skylion007 @dcci @manuelcandales